Bug 184270 - Make SessionStorage work with process swapping
Summary: Make SessionStorage work with process swapping
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-03 10:38 PDT by Brady Eidson
Modified: 2018-04-03 13:01 PDT (History)
5 users (show)

See Also:


Attachments
Patch (11.22 KB, patch)
2018-04-03 11:05 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (11.16 KB, patch)
2018-04-03 11:26 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2018-04-03 10:38:16 PDT
Make SessionStorage work with process swapping
Comment 1 Brady Eidson 2018-04-03 10:38:27 PDT
<rdar://problem/38773193>
Comment 2 Brady Eidson 2018-04-03 11:05:37 PDT
Created attachment 337090 [details]
Patch
Comment 3 EWS Watchlist 2018-04-03 11:08:30 PDT
Attachment 337090 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:613:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:622:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:629:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Andy Estes 2018-04-03 11:17:10 PDT
Comment on attachment 337090 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337090&action=review

> Source/WebKit/ChangeLog:8
> +        Do to a minor process accounting error, WebPageProxys weren't always being reconnected with their

"do to"

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:634
> +    processPoolConfiguration.get().processSwapsOnNavigation = YES;

I think we prefer [processPoolConfiguration setProcessSwapsOnNavigation:YES] (to avoid the ugly .get())

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:640
> +    RetainPtr<PSONScheme> handler1 = adoptNS([[PSONScheme alloc] initWithBytes:sessionStorageTestBytes]);
> +    RetainPtr<PSONScheme> handler2 = adoptNS([[PSONScheme alloc] init]);

auto

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:644
> +    RetainPtr<PSONMessageHandler> messageHandler = adoptNS([[PSONMessageHandler alloc] init]);

auto
Comment 5 Brady Eidson 2018-04-03 11:26:06 PDT
Created attachment 337098 [details]
Patch
Comment 6 Brady Eidson 2018-04-03 11:26:28 PDT
Comment on attachment 337098 [details]
Patch

Waiting for EWS
Comment 7 EWS Watchlist 2018-04-03 11:37:21 PDT
Attachment 337098 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:613:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:622:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:629:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 WebKit Commit Bot 2018-04-03 13:01:31 PDT
Comment on attachment 337098 [details]
Patch

Clearing flags on attachment: 337098

Committed r230219: <https://trac.webkit.org/changeset/230219>
Comment 9 WebKit Commit Bot 2018-04-03 13:01:33 PDT
All reviewed patches have been landed.  Closing bug.