Make SessionStorage work with process swapping
<rdar://problem/38773193>
Created attachment 337090 [details] Patch
Attachment 337090 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:613: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:622: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:629: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 337090 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337090&action=review > Source/WebKit/ChangeLog:8 > + Do to a minor process accounting error, WebPageProxys weren't always being reconnected with their "do to" > Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:634 > + processPoolConfiguration.get().processSwapsOnNavigation = YES; I think we prefer [processPoolConfiguration setProcessSwapsOnNavigation:YES] (to avoid the ugly .get()) > Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:640 > + RetainPtr<PSONScheme> handler1 = adoptNS([[PSONScheme alloc] initWithBytes:sessionStorageTestBytes]); > + RetainPtr<PSONScheme> handler2 = adoptNS([[PSONScheme alloc] init]); auto > Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:644 > + RetainPtr<PSONMessageHandler> messageHandler = adoptNS([[PSONMessageHandler alloc] init]); auto
Created attachment 337098 [details] Patch
Comment on attachment 337098 [details] Patch Waiting for EWS
Attachment 337098 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:613: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:622: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:629: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 337098 [details] Patch Clearing flags on attachment: 337098 Committed r230219: <https://trac.webkit.org/changeset/230219>
All reviewed patches have been landed. Closing bug.