Bug 184259 – [SOUP] Stop using ResourceHandle to load GResources

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Carlos Garcia Campos]

GResources are loaded in the WebProcess using ResourceHandle because soup handles them transparently. But now that we no longer use ResourceHandle, we can add a simple loader for GResources, similar to the one used for data URLS, since loading a GResource is a matter of calling g_resources_lookup_data() in the end.

[Carlos Garcia Campos]

Created attachment 337068 [details]
Patch

[Sergio Villar Senin]

Comment on attachment 337068 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337068&action=review

> Source/WebCore/platform/glib/SharedBufferGlib.cpp:30
> +SharedBuffer::SharedBuffer(GBytes* bytes)

I guess this can be a reference since it cannot be null.

> Source/WebCore/platform/glib/SharedBufferGlib.cpp:37
> +Ref<SharedBuffer> SharedBuffer::create(GBytes* bytes)

Ditto.

[Carlos Garcia Campos]

(In reply to Sergio Villar Senin from comment #2)
> Comment on attachment 337068 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=337068&action=review
> 
> > Source/WebCore/platform/glib/SharedBufferGlib.cpp:30
> > +SharedBuffer::SharedBuffer(GBytes* bytes)
> 
> I guess this can be a reference since it cannot be null.

Nop, we never use references for C structs.

> > Source/WebCore/platform/glib/SharedBufferGlib.cpp:37
> > +Ref<SharedBuffer> SharedBuffer::create(GBytes* bytes)
> 
> Ditto.

[Carlos Garcia Campos]

Committed r230203: <https://trac.webkit.org/changeset/230203>

[Radar WebKit Bug Importer]

<rdar://problem/39140990>

[Sergio Villar Senin]

(In reply to Carlos Garcia Campos from comment #3)
> (In reply to Sergio Villar Senin from comment #2)
> > Comment on attachment 337068 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=337068&action=review
> > 
> > > Source/WebCore/platform/glib/SharedBufferGlib.cpp:30
> > > +SharedBuffer::SharedBuffer(GBytes* bytes)
> > 
> > I guess this can be a reference since it cannot be null.
> 
> Nop, we never use references for C structs.

:) next time I'll check the actual type