See: https://github.com/w3c/csswg-drafts/issues/670#issuecomment-366329393 Relevant part of the spec: https://drafts.csswg.org/cssom/#serialize-a-css-component-value > Let list be a list of CSS component values belonging to <counter>, omitting the last CSS component value if it is "decimal". Test: http://w3c-test.org/css/cssom/serialize-values.html (search for "counter") > Fail content: counter(par-num) assert_equals: content raw inline style declaration expected "counter(par-num)" but got "counter(par-num, decimal)" This test passes in Chromium canary and Firefox Nightly. It fails in WebKit TP and EdgeHTML 16 (tested in browserstack).
<rdar://problem/41114169>
Created attachment 430820 [details] Patch
Created attachment 430829 [details] Patch
Created attachment 430830 [details] Patch
Comment on attachment 430830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430830&action=review > Source/WebCore/css/CSSPrimitiveValue.cpp:1085 > + if (listStyle == "decimal") > + listStyle = emptyString(); > result.append(listStyle.isEmpty() ? "" : ", ", listStyle, ')'); This seems like it would be a bit cleaner as: if (!(listStyle.empty() || listStyle == "decimal")) result.append(", ", listStyle); result.append(')'); (or something like that).
Created attachment 430879 [details] Patch
Created attachment 430881 [details] Patch
Committed r278648 (238630@main): <https://commits.webkit.org/238630@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430881 [details].