Bug 184252 - [Extra zoom mode] Update time picker to use platform view controller
Summary: [Extra zoom mode] Update time picker to use platform view controller
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-02 19:10 PDT by Wenson Hsieh
Modified: 2018-04-03 12:22 PDT (History)
6 users (show)

See Also:


Attachments
Patch (20.80 KB, patch)
2018-04-02 19:23 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Rebase on master (20.16 KB, patch)
2018-04-02 19:28 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Fix ChangeLog typo (20.15 KB, patch)
2018-04-03 11:11 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-04-02 19:10:43 PDT
<rdar://problem/38804795>
Comment 1 Wenson Hsieh 2018-04-02 19:23:07 PDT
Created attachment 337053 [details]
Patch
Comment 2 Wenson Hsieh 2018-04-02 19:28:18 PDT
Created attachment 337054 [details]
Rebase on master
Comment 3 Wenson Hsieh 2018-04-03 09:31:33 PDT
Comment on attachment 337054 [details]
Rebase on master

View in context: https://bugs.webkit.org/attachment.cgi?id=337054&action=review

> Source/WebKit/ChangeLog:9
> +        Adjust for some small changes in WKTimePickerViewController changes, and remove some files that we no longer need.

Oops, s/changes in WKTimePickerViewController changes/WKTimePickerViewController changes/
Comment 4 Wenson Hsieh 2018-04-03 11:11:36 PDT
Created attachment 337093 [details]
Fix ChangeLog typo
Comment 5 WebKit Commit Bot 2018-04-03 12:22:57 PDT
Comment on attachment 337093 [details]
Fix ChangeLog typo

Clearing flags on attachment: 337093

Committed r230217: <https://trac.webkit.org/changeset/230217>
Comment 6 WebKit Commit Bot 2018-04-03 12:22:59 PDT
All reviewed patches have been landed.  Closing bug.