Bug 184241 - Define AVKit softlink macro
Summary: Define AVKit softlink macro
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-02 11:38 PDT by Eric Carlson
Modified: 2018-04-02 13:34 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.52 KB, patch)
2018-04-02 12:46 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2018-04-02 11:38:50 PDT 
Define AVKit softlink macro
Comment 1 Eric Carlson 2018-04-02 12:46:54 PDT 
Created attachment 337014 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2018-04-02 12:47:56 PDT 
<rdar://problem/39115023>
Comment 3 Jer Noble 2018-04-02 13:03:21 PDT 
Comment on attachment 337014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337014&action=review

> Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.h:39
> +#if ENABLE(EXTRA_ZOOM_MODE)
> +#define SOFTLINK_AVKIT_FRAMEWORK() SOFT_LINK_PRIVATE_FRAMEWORK_OPTIONAL(AVKit)
> +#else
> +#define SOFTLINK_AVKIT_FRAMEWORK() SOFT_LINK_FRAMEWORK_OPTIONAL(AVKit)
> +#endif
> +

Nit: We should eventually move this into an "AVKitSoftLink.h" header and matching source file.
Comment 4 WebKit Commit Bot 2018-04-02 13:34:13 PDT 
Comment on attachment 337014 [details]
Patch

Clearing flags on attachment: 337014

Committed r230177: <https://trac.webkit.org/changeset/230177>
Comment 5 WebKit Commit Bot 2018-04-02 13:34:15 PDT 
All reviewed patches have been landed.  Closing bug.