Use NetworkLoadChecker to handle synchronous HTTP loads. This should help fixing limitations of sync XHR for instance and will require beefing up NetworkLoadChecker.
Created attachment 337009 [details] Patch
Comment on attachment 337009 [details] Patch Attachment 337009 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7181210 New failing tests: http/tests/xmlhttprequest/cross-origin-no-authorization.html http/tests/xmlhttprequest/access-control-and-redirects.html imported/w3c/web-platform-tests/XMLHttpRequest/access-control-and-redirects.htm http/tests/xmlhttprequest/access-control-preflight-not-successful.html
Created attachment 337013 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 337009 [details] Patch Attachment 337009 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7181235 New failing tests: http/tests/xmlhttprequest/cross-origin-no-authorization.html http/tests/xmlhttprequest/access-control-and-redirects.html imported/w3c/web-platform-tests/XMLHttpRequest/access-control-and-redirects.htm http/tests/xmlhttprequest/access-control-preflight-not-successful.html
Created attachment 337017 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 337009 [details] Patch Attachment 337009 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7181355 New failing tests: http/tests/local/fileapi/file-last-modified-after-delete-using-open-panel.html http/wpt/beacon/cors/cors-redirect-failure.html http/tests/local/fileapi/file-last-modified-using-open-panel.html http/tests/local/formdata/send-form-data-constructed-from-form-using-open-panel.html http/tests/local/blob/send-data-blob.html http/tests/local/formdata/send-form-data-with-string-containing-null.html
Created attachment 337022 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 337033 [details] Patch
Comment on attachment 337033 [details] Patch Attachment 337033 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7184407 New failing tests: http/tests/xmlhttprequest/access-control-and-redirects.html
Created attachment 337041 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 337033 [details] Patch Attachment 337033 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7184511 New failing tests: fast/files/apply-blob-url-to-xhr-using-open-panel.html storage/indexeddb/modern/blob-svg-image.html media/video-src-blob-using-open-panel.html fast/files/apply-blob-url-to-img-using-open-panel.html fast/history/page-cache-createObjectURL-using-open-panel.html storage/indexeddb/modern/blob-cursor.html fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download-async-delegate.html
Created attachment 337042 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 337033 [details] Patch Attachment 337033 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7184373 New failing tests: http/tests/xmlhttprequest/access-control-and-redirects.html
Created attachment 337043 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 337033 [details] Patch Attachment 337033 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7184969 New failing tests: http/tests/xmlhttprequest/cross-origin-no-authorization.html http/tests/xmlhttprequest/access-control-and-redirects.html http/tests/xmlhttprequest/access-control-preflight-not-successful.html
Created attachment 337045 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 337056 [details] Patch
Created attachment 337058 [details] Patch
Comment on attachment 337058 [details] Patch Attachment 337058 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7189124 New failing tests: http/tests/xmlhttprequest/cross-origin-no-authorization.html http/tests/xmlhttprequest/access-control-and-redirects.html http/tests/xmlhttprequest/access-control-preflight-not-successful.html
Created attachment 337062 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 337058 [details] Patch Attachment 337058 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7189876 New failing tests: http/tests/xmlhttprequest/cross-origin-no-authorization.html http/tests/xmlhttprequest/access-control-and-redirects.html http/tests/xmlhttprequest/access-control-preflight-not-successful.html
Created attachment 337065 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 337083 [details] Patch
Created attachment 337095 [details] Patch
It looks like the patch doesn't apply on ToT?
Created attachment 337108 [details] Patch
<rdar://problem/39160180>
Comment on attachment 337108 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337108&action=review > Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:378 > + WebProcess::singleton().ensureNetworkProcessConnection().connection().send(Messages::NetworkConnectionToWebProcess::AddOriginAccessWhitelistEntry { sourceOrigin, destinationProtocol, destinationHost, allowDestinationSubdomains }, 0); If we do these things in one WebProcess, are we sure we want to do them in the network process? That would affect other web processes
Created attachment 337719 [details] Rebased
Created attachment 337722 [details] Rebased
Created attachment 337724 [details] Patch
Comment on attachment 337724 [details] Patch Attachment 337724 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7286806 New failing tests: imported/w3c/web-platform-tests/XMLHttpRequest/access-control-preflight-headers-sync.htm imported/w3c/web-platform-tests/XMLHttpRequest/allow-lists-starting-with-comma.htm imported/w3c/web-platform-tests/XMLHttpRequest/access-control-basic-allow-non-cors-safelisted-method.htm http/tests/xmlhttprequest/access-control-response-with-body-sync.html http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies.php http/tests/xmlhttprequest/access-control-preflight-credential-sync.html imported/w3c/web-platform-tests/XMLHttpRequest/access-control-basic-non-cors-safelisted-content-type.htm http/tests/xmlhttprequest/access-control-basic-non-simple-deny-cached.html http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma.html http/tests/xmlhttprequest/access-control-preflight-headers-sync.html http/tests/xmlhttprequest/access-control-basic-non-simple-allow.html imported/w3c/web-platform-tests/XMLHttpRequest/access-control-response-with-body-sync.htm imported/w3c/web-platform-tests/XMLHttpRequest/access-control-preflight-credential-sync.htm
Created attachment 337733 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Comment on attachment 337724 [details] Patch Attachment 337724 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7288478 New failing tests: imported/w3c/web-platform-tests/XMLHttpRequest/access-control-preflight-headers-sync.htm imported/w3c/web-platform-tests/XMLHttpRequest/allow-lists-starting-with-comma.htm imported/w3c/web-platform-tests/XMLHttpRequest/access-control-basic-allow-non-cors-safelisted-method.htm http/tests/xmlhttprequest/access-control-response-with-body-sync.html http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies.php http/tests/xmlhttprequest/access-control-preflight-credential-sync.html imported/w3c/web-platform-tests/XMLHttpRequest/access-control-basic-non-cors-safelisted-content-type.htm http/tests/xmlhttprequest/access-control-basic-non-simple-deny-cached.html http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma.html http/tests/xmlhttprequest/access-control-preflight-headers-sync.html http/tests/xmlhttprequest/access-control-basic-non-simple-allow.html imported/w3c/web-platform-tests/XMLHttpRequest/access-control-response-with-body-sync.htm imported/w3c/web-platform-tests/XMLHttpRequest/access-control-preflight-credential-sync.htm
Created attachment 337754 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 337724 [details] Patch Attachment 337724 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7288622 New failing tests: imported/w3c/web-platform-tests/XMLHttpRequest/access-control-preflight-headers-sync.htm imported/w3c/web-platform-tests/XMLHttpRequest/allow-lists-starting-with-comma.htm imported/w3c/web-platform-tests/XMLHttpRequest/access-control-basic-allow-non-cors-safelisted-method.htm http/tests/xmlhttprequest/access-control-response-with-body-sync.html http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies.php http/tests/xmlhttprequest/access-control-preflight-credential-sync.html imported/w3c/web-platform-tests/XMLHttpRequest/access-control-basic-non-cors-safelisted-content-type.htm http/tests/xmlhttprequest/access-control-basic-non-simple-deny-cached.html http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma.html http/tests/xmlhttprequest/access-control-preflight-headers-sync.html http/tests/xmlhttprequest/access-control-basic-non-simple-allow.html imported/w3c/web-platform-tests/XMLHttpRequest/access-control-response-with-body-sync.htm imported/w3c/web-platform-tests/XMLHttpRequest/access-control-preflight-credential-sync.htm
Created attachment 337759 [details] Archive of layout-test-results from ews105 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 337776 [details] Patch
Created attachment 338009 [details] Patch
Created attachment 338010 [details] Patch
Created attachment 338016 [details] Patch
Created attachment 338025 [details] Patch
Comment on attachment 338025 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338025&action=review > LayoutTests/ChangeLog:3 > + Preventively expect UTF8 strings from libwebrtc SDP and error messages Bad changelog. > LayoutTests/ChangeLog:19 > + Test should check for actual request header and not header name in Access-Control-Request-Headers. Why? > LayoutTests/http/wpt/beacon/cors/cors-preflight-blob-failure.html:42 > + assert_false(requested_headers.includes("referer"), "Referer header is requested") Why is this right? > LayoutTests/http/wpt/beacon/cors/cors-preflight-blob-failure.html:43 > + assert_false(requested_headers.includes("origin"), "Origin header is requested") Why is this right? > LayoutTests/http/wpt/beacon/cors/cors-preflight-blob-success.html:43 > + assert_false(requested_headers.includes("referer"), "Referer header is requested") Why is this right? > LayoutTests/http/wpt/beacon/cors/cors-preflight-blob-success.html:44 > + assert_false(requested_headers.includes("origin"), "Origin header is requested") Why is this right?
(In reply to Chris Dumez from comment #43) > Comment on attachment 338025 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=338025&action=review > > > LayoutTests/ChangeLog:3 > > + Preventively expect UTF8 strings from libwebrtc SDP and error messages > > Bad changelog. > > > LayoutTests/ChangeLog:19 > > + Test should check for actual request header and not header name in Access-Control-Request-Headers. > > Why? As per fetch spec, we should use the referrer of the original request. But Referrer header is not an application header. It is set on the request after the preflight has been done. So it should not appear in the list of application headers, ditto for Origin header. > > > LayoutTests/http/wpt/beacon/cors/cors-preflight-blob-failure.html:42 > > + assert_false(requested_headers.includes("referer"), "Referer header is requested") > > Why is this right? Referrer should not be in ACAH but should be present as a header. Ditto for Origin.
Created attachment 338041 [details] Patch for landing
Comment on attachment 338041 [details] Patch for landing Clearing flags on attachment: 338041 Committed r230681: <https://trac.webkit.org/changeset/230681>
All reviewed patches have been landed. Closing bug.
*** Bug 184148 has been marked as a duplicate of this bug. ***