RESOLVED FIXED 184197
[Cocoa] Fix some internal builds that consume WebDriver atoms 
https://bugs.webkit.org/show_bug.cgi?id=184197
Summary [Cocoa] Fix some internal builds that consume WebDriver atoms
Blaze Burg
Reported 2018-03-30 15:45:53 PDT
.
Attachments
Patch (3.36 KB, patch)
2018-03-30 16:14 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Patch (7.40 KB, patch)
2018-04-02 15:55 PDT, Blaze Burg 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2018-03-30 16:14:18 PDT
Created attachment 336893 [details] Patch
Blaze Burg
Comment 3 2018-04-02 15:55:16 PDT
Created attachment 337039 [details] Patch
Blaze Burg
Comment 4 2018-04-02 15:56:19 PDT
<rdar://problem/39023240>
mitz
Comment 5 2018-04-02 16:08:44 PDT
Comment on attachment 337039 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337039&action=review > Source/WebKit/WebKit.xcodeproj/project.pbxproj:9865 > + 99CA3862207286DB00BAD578 /* Copy WebDriver Atoms to Framework Private Headers */, It’s probably best to keep this ordered before the Frameworks phase (where the old copy phased used to be).
Blaze Burg
Comment 6 2018-04-02 16:16:05 PDT
Comment on attachment 337039 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337039&action=review >> Source/WebKit/WebKit.xcodeproj/project.pbxproj:9865 >> + 99CA3862207286DB00BAD578 /* Copy WebDriver Atoms to Framework Private Headers */, > > It’s probably best to keep this ordered before the Frameworks phase (where the old copy phased used to be). OK
Blaze Burg
Comment 7 2018-04-02 17:11:21 PDT
Committed r230193: <https://trac.webkit.org/changeset/230193>
Note You need to log in before you can comment on or make changes to this bug.