Bug 184196 – REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

The following API tests fail when run on iOS Simulator using the 11.3 SDK:

  WKWebViewAutofillTests.StandalonePasswordField
  WKWebViewAutofillTests.UsernameAndPasswordField
  WKWebViewAutofillTests.UsernameAndPasswordFieldSeparatedByRadioButton

FAIL WKWebViewAutofillTests.StandalonePasswordField

/Volumes/Data/slave/ios-simulator-11-debug/build/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:178
Value of: [webView stringByEvaluatingJavaScript:@"password.value"]
  Actual: ""
Expected: "famos"

FAIL WKWebViewAutofillTests.UsernameAndPasswordField

/Volumes/Data/slave/ios-simulator-11-debug/build/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:131
Value of: [webView stringByEvaluatingJavaScript:@"password.value"]
  Actual: ""
Expected: "famos"

FAIL WKWebViewAutofillTests.UsernameAndPasswordFieldSeparatedByRadioButton

/Volumes/Data/slave/ios-simulator-11-debug/build/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:150
Value of: [webView stringByEvaluatingJavaScript:@"user.value"]
  Actual: ""
Expected: "frederik"


/Volumes/Data/slave/ios-simulator-11-debug/build/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:151
Value of: [webView stringByEvaluatingJavaScript:@"password.value"]
  Actual: ""
Expected: "famos"

[Radar WebKit Bug Importer]

<rdar://problem/39054481>

[Ryan Haddad]

Disabled tests in https://trac.webkit.org/r230288

[Frederik Riedel]

Any idea what the reason for the test failure in the simulator is in comparison to testing on a real device? I'm not sure why the tests fail there...

[Wenson Hsieh]

(In reply to Frederik Riedel from comment #3)
> Any idea what the reason for the test failure in the simulator is in
> comparison to testing on a real device? I'm not sure why the tests fail
> there...

Unsure, as of yet. I'll take a look!

[Wenson Hsieh]

(In reply to Wenson Hsieh from comment #4)
> (In reply to Frederik Riedel from comment #3)
> > Any idea what the reason for the test failure in the simulator is in
> > comparison to testing on a real device? I'm not sure why the tests fail
> > there...
> 
> Unsure, as of yet. I'll take a look!

Finally took a peek at this. -insertTextSuggestion: requires that the UITextSuggestion is a UITextAutofillSuggestion. However, the UITextAutofillSuggestion @implementation hack in WKWebViewAutofillTests is being used since developer SDKs do not have the private header, so we fail the class check. We no longer need the compatibility hack in WKWebViewAutofillTests since our bots don't run these tests on < iOS 11.3 anymore, so we can just fix these tests by removing it.

[Wenson Hsieh]

Created attachment 339572 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 339572 [details]
Patch

Clearing flags on attachment: 339572

Committed r231369: <https://trac.webkit.org/changeset/231369>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.