Bug 184194 - JSObject shouldn't do index masking
Summary: JSObject shouldn't do index masking
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-30 14:17 PDT by Filip Pizlo
Modified: 2018-04-01 12:00 PDT (History)
9 users (show)

See Also:

Attachments
kill it with fire (69.03 KB, patch)
2018-03-30 15:12 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
more (88.93 KB, patch)
2018-03-31 09:09 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
more (102.58 KB, patch)
2018-03-31 09:21 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
more (125.32 KB, patch)
2018-03-31 09:33 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
getting close (125.70 KB, patch)
2018-03-31 10:25 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
this might be the one (128.87 KB, patch)
2018-03-31 12:51 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
fix WebCore (130.43 KB, patch)
2018-03-31 12:59 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
fix 32-bit (131.83 KB, patch)
2018-03-31 13:08 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (144.09 KB, patch)
2018-03-31 14:23 PDT, Filip Pizlo 		ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews114 for mac-sierra (3.38 MB, application/zip)
2018-03-31 16:20 PDT, EWS Watchlist 		no flags Details
the patch (144.45 KB, patch)
2018-03-31 18:05 PDT, Filip Pizlo 		ysuzuki: review+
Details | Formatted Diff | Diff
Show Obsolete (10) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2018-03-30 14:17:23 PDT 
...
Comment 1 Filip Pizlo 2018-03-30 15:12:35 PDT 
Created attachment 336891 [details]
kill it with fire
Comment 2 Filip Pizlo 2018-03-31 09:09:37 PDT 
Created attachment 336923 [details]
more
Comment 3 Filip Pizlo 2018-03-31 09:21:57 PDT 
Created attachment 336924 [details]
more
Comment 4 Filip Pizlo 2018-03-31 09:33:48 PDT 
Created attachment 336925 [details]
more
Comment 5 Filip Pizlo 2018-03-31 10:25:10 PDT 
Created attachment 336926 [details]
getting close

I managed to introduce a weird GC bug, but a lot of tests are now passing.
Comment 6 Filip Pizlo 2018-03-31 12:51:01 PDT 
Created attachment 336930 [details]
this might be the one
Comment 7 Filip Pizlo 2018-03-31 12:59:50 PDT 
Created attachment 336931 [details]
fix WebCore
Comment 8 Filip Pizlo 2018-03-31 13:08:17 PDT 
Created attachment 336932 [details]
fix 32-bit
Comment 9 Filip Pizlo 2018-03-31 14:23:35 PDT 
Created attachment 336933 [details]
the patch
Comment 10 EWS Watchlist 2018-03-31 15:43:23 PDT 
Comment on attachment 336933 [details]
the patch

Attachment 336933 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/7160791

New failing tests:
stress/ftl-get-by-id-getter-exception-interesting-live-state.js.ftl-eager
Comment 11 Filip Pizlo 2018-03-31 16:11:11 PDT 
(In reply to Build Bot from comment #10)
> Comment on attachment 336933 [details]
> the patch
> 
> Attachment 336933 [details] did not pass jsc-ews (mac):
> Output: http://webkit-queues.webkit.org/results/7160791
> 
> New failing tests:
> stress/ftl-get-by-id-getter-exception-interesting-live-state.js.ftl-eager

I think that this is a pre-existing flake.
Comment 12 EWS Watchlist 2018-03-31 16:20:50 PDT 
Comment on attachment 336933 [details]
the patch

Attachment 336933 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7160898

New failing tests:
wasm/iframe-postmessage.html
workers/wasm-hashset.html
workers/wasm-mem-post-message.html
wasm/iframe-parent-postmessage.html
wasm/window-postmessage.html
workers/wasm-long-compile.html
Comment 13 EWS Watchlist 2018-03-31 16:20:51 PDT 
Created attachment 336935 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 14 Filip Pizlo 2018-03-31 18:05:22 PDT 
Created attachment 336940 [details]
the patch
Comment 15 Yusuke Suzuki 2018-04-01 10:12:44 PDT 
Comment on attachment 336940 [details]
the patch

r=me
Comment 16 Filip Pizlo 2018-04-01 11:59:40 PDT 
Landed in https://trac.webkit.org/changeset/230144/webkit
Comment 17 Radar WebKit Bug Importer 2018-04-01 12:00:35 PDT 
<rdar://problem/39088546>