184183 – The WebContent process should not process incoming IPC while waiting for a sync IPC reply

RESOLVED FIXED 184183

The WebContent process should not process incoming IPC while waiting for a sync IPC reply

https://bugs.webkit.org/show_bug.cgi?id=184183

Summary The WebContent process should not process incoming IPC while waiting for a sy...

Chris Dumez

Reported 2018-03-30 10:23:23 PDT

The WebContent process should not process incoming IPC while waiting for a sync IPC reply.

Attachments
Patch (23.96 KB, patch) 2018-03-30 10:39 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (24.80 KB, patch) 2018-03-30 10:44 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (24.86 KB, patch) 2018-03-30 10:50 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-sierra-wk2 (593.53 KB, application/zip) 2018-03-30 11:42 PDT, EWS Watchlist	no flags	Details
Patch (24.91 KB, patch) 2018-03-30 12:08 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (24.13 KB, patch) 2018-03-30 13:03 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.61 MB, application/zip) 2018-03-30 14:11 PDT, EWS Watchlist	no flags	Details
Patch (24.19 KB, patch) 2018-04-05 08:19 PDT, Chris Dumez	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.65 MB, application/zip) 2018-04-05 09:30 PDT, EWS Watchlist	no flags	Details
WIP Patch (29.63 KB, patch) 2018-09-25 15:21 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (29.63 KB, patch) 2018-09-25 15:26 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (28.66 KB, patch) 2018-09-25 16:46 PDT, Chris Dumez	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.27 MB, application/zip) 2018-09-25 18:04 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.31 MB, application/zip) 2018-09-25 19:00 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (95.54 MB, application/zip) 2018-09-25 20:45 PDT, EWS Watchlist	no flags	Details
WIP Patch (28.66 KB, patch) 2018-09-26 11:47 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.21 MB, application/zip) 2018-09-26 13:12 PDT, EWS Watchlist	no flags	Details
Patch (37.18 KB, patch) 2018-09-26 13:51 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (36.21 KB, patch) 2018-09-26 15:19 PDT, Chris Dumez	rniwa: review+ rniwa: commit-queue-	Details Formatted Diff Diff
Show Obsolete (18) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2018-03-30 10:24:29 PDT

<rdar://problem/36800576>

Chris Dumez

Comment 2 2018-03-30 10:39:21 PDT

Created attachment 336867 [details] Patch

Chris Dumez

Comment 3 2018-03-30 10:44:19 PDT

Created attachment 336869 [details] Patch

Chris Dumez

Comment 4 2018-03-30 10:50:32 PDT

Created attachment 336870 [details] Patch

EWS Watchlist

Comment 5 2018-03-30 10:52:36 PDT

Attachment 336870 [details] did not pass style-queue: ERROR: Source/WebKit/ChangeLog:10: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: security bug [changelog/unwantedsecurityterms] [3] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 6 2018-03-30 11:42:13 PDT

Comment on attachment 336870 [details] Patch Attachment 336870 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7149541 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 7 2018-03-30 11:42:14 PDT

Created attachment 336875 [details] Archive of layout-test-results from ews105 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Chris Dumez

Comment 8 2018-03-30 12:08:27 PDT

Created attachment 336877 [details] Patch

EWS Watchlist

Comment 9 2018-03-30 12:10:57 PDT

Attachment 336877 [details] did not pass style-queue: ERROR: Source/WebKit/ChangeLog:10: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: security bug [changelog/unwantedsecurityterms] [3] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 10 2018-03-30 13:03:15 PDT

Created attachment 336881 [details] Patch

EWS Watchlist

Comment 11 2018-03-30 13:05:32 PDT

Attachment 336881 [details] did not pass style-queue: ERROR: Source/WebKit/ChangeLog:10: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: security bug [changelog/unwantedsecurityterms] [3] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 12 2018-03-30 14:11:14 PDT

Comment on attachment 336881 [details] Patch Attachment 336881 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7151306 New failing tests: plugins/npp-set-window-called-during-destruction.html

EWS Watchlist

Comment 13 2018-03-30 14:11:15 PDT

Created attachment 336886 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Chris Dumez

Comment 14 2018-04-05 08:19:28 PDT

Created attachment 337263 [details] Patch

EWS Watchlist

Comment 15 2018-04-05 08:20:59 PDT

Attachment 337263 [details] did not pass style-queue: ERROR: Source/WebKit/ChangeLog:10: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: security bug [changelog/unwantedsecurityterms] [3] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 16 2018-04-05 09:30:38 PDT

Comment on attachment 337263 [details] Patch Attachment 337263 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7215713 New failing tests: plugins/npp-set-window-called-during-destruction.html

EWS Watchlist

Comment 17 2018-04-05 09:30:39 PDT

Created attachment 337268 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Chris Dumez

Comment 18 2018-09-25 15:21:57 PDT

Created attachment 350800 [details] WIP Patch

Chris Dumez

Comment 19 2018-09-25 15:26:38 PDT

Created attachment 350801 [details] WIP Patch

Chris Dumez

Comment 20 2018-09-25 16:46:32 PDT

Created attachment 350810 [details] WIP Patch

EWS Watchlist

Comment 21 2018-09-25 18:04:24 PDT

Comment on attachment 350810 [details] WIP Patch Attachment 350810 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9350431 New failing tests: fast/frames/flattening/iframe-tiny.html js/dom/math-random-initial-values.html

EWS Watchlist

Comment 22 2018-09-25 18:04:26 PDT

Created attachment 350822 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 23 2018-09-25 18:59:59 PDT

EWS Watchlist

Comment 24 2018-09-25 19:00:01 PDT

Created attachment 350831 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 25 2018-09-25 20:45:27 PDT

Comment on attachment 350810 [details] WIP Patch Attachment 350810 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9351478 New failing tests: editing/undo/remove-css-property-and-remove-style.html editing/undo/redo-split-text-node.html editing/undo/4063751.html editing/pasteboard/undoable-fragment-removes.html editing/undo/undo-after-setting-value.html editing/execCommand/delete-selection-has-style.html editing/deleting/delete-and-undo.html editing/undo/replace-by-span-then-remove.html editing/deleting/paragraph-in-preserveNewline.html editing/inserting/redo.html editing/undo/redo-split-text-with-removal.html editing/style/stylewithcss-without-selection.html editing/deleting/whitespace-pre-1.html editing/execCommand/format-block-multiple-paragraphs-in-pre.html

EWS Watchlist

Comment 26 2018-09-25 20:45:31 PDT

Created attachment 350842 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Chris Dumez

Comment 27 2018-09-26 11:47:15 PDT

Created attachment 350875 [details] WIP Patch

EWS Watchlist

Comment 28 2018-09-26 13:12:25 PDT

Comment on attachment 350875 [details] WIP Patch Attachment 350875 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9358667 New failing tests: editing/pasteboard/emacs-ctrl-a-k-y.html

EWS Watchlist

Comment 29 2018-09-26 13:12:27 PDT

Created attachment 350890 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Chris Dumez

Comment 30 2018-09-26 13:51:00 PDT

Created attachment 350897 [details] Patch

Chris Dumez

Comment 31 2018-09-26 15:19:14 PDT

Created attachment 350914 [details] Patch

Ryosuke Niwa

Comment 32 2018-09-26 18:53:30 PDT

Comment on attachment 350914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350914&action=review > Source/WebKit/ChangeLog:16 > + IPC while waiting for a a synchronous IPC reply, expect in cases where it would cause a deadlock. waiting for "a a" > Source/WebKit/ChangeLog:18 > + As a result, this patch also dropts support for the DoNotProcessIncomingMessagesWhenWaitingForSyncReply drop*t*s

Chris Dumez

Comment 33 2018-09-27 08:57:13 PDT

Committed r236546: <https://trac.webkit.org/changeset/236546>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component WebKit2

Assignee

Chris Dumez

Reported

2018-03-30 10:23 PDT

Modified

2018-09-27 08:57 PDT History

CC List

3 users Show

URL

Keywords InRadar

Depends on

189927 190007

Blocks

Dependencies

tree graph