Bug 184183 - The WebContent process should not process incoming IPC while waiting for a sync IPC reply
Summary: The WebContent process should not process incoming IPC while waiting for a sy...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 189927 190007
Blocks:
  Show dependency treegraph
 
Reported: 2018-03-30 10:23 PDT by Chris Dumez
Modified: 2018-09-27 08:57 PDT (History)
3 users (show)

See Also:


Attachments
Patch (23.96 KB, patch)
2018-03-30 10:39 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (24.80 KB, patch)
2018-03-30 10:44 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (24.86 KB, patch)
2018-03-30 10:50 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-sierra-wk2 (593.53 KB, application/zip)
2018-03-30 11:42 PDT, EWS Watchlist
no flags Details
Patch (24.91 KB, patch)
2018-03-30 12:08 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (24.13 KB, patch)
2018-03-30 13:03 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.61 MB, application/zip)
2018-03-30 14:11 PDT, EWS Watchlist
no flags Details
Patch (24.19 KB, patch)
2018-04-05 08:19 PDT, Chris Dumez
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.65 MB, application/zip)
2018-04-05 09:30 PDT, EWS Watchlist
no flags Details
WIP Patch (29.63 KB, patch)
2018-09-25 15:21 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP Patch (29.63 KB, patch)
2018-09-25 15:26 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP Patch (28.66 KB, patch)
2018-09-25 16:46 PDT, Chris Dumez
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.27 MB, application/zip)
2018-09-25 18:04 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.31 MB, application/zip)
2018-09-25 19:00 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (95.54 MB, application/zip)
2018-09-25 20:45 PDT, EWS Watchlist
no flags Details
WIP Patch (28.66 KB, patch)
2018-09-26 11:47 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.21 MB, application/zip)
2018-09-26 13:12 PDT, EWS Watchlist
no flags Details
Patch (37.18 KB, patch)
2018-09-26 13:51 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (36.21 KB, patch)
2018-09-26 15:19 PDT, Chris Dumez
rniwa: review+
rniwa: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-03-30 10:23:23 PDT
The WebContent process should not process incoming IPC while waiting for a sync IPC reply.
Comment 1 Chris Dumez 2018-03-30 10:24:29 PDT
<rdar://problem/36800576>
Comment 2 Chris Dumez 2018-03-30 10:39:21 PDT
Created attachment 336867 [details]
Patch
Comment 3 Chris Dumez 2018-03-30 10:44:19 PDT
Created attachment 336869 [details]
Patch
Comment 4 Chris Dumez 2018-03-30 10:50:32 PDT
Created attachment 336870 [details]
Patch
Comment 5 EWS Watchlist 2018-03-30 10:52:36 PDT
Attachment 336870 [details] did not pass style-queue:


ERROR: Source/WebKit/ChangeLog:10:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: security bug  [changelog/unwantedsecurityterms] [3]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 EWS Watchlist 2018-03-30 11:42:13 PDT
Comment on attachment 336870 [details]
Patch

Attachment 336870 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7149541

Number of test failures exceeded the failure limit.
Comment 7 EWS Watchlist 2018-03-30 11:42:14 PDT
Created attachment 336875 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 8 Chris Dumez 2018-03-30 12:08:27 PDT
Created attachment 336877 [details]
Patch
Comment 9 EWS Watchlist 2018-03-30 12:10:57 PDT
Attachment 336877 [details] did not pass style-queue:


ERROR: Source/WebKit/ChangeLog:10:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: security bug  [changelog/unwantedsecurityterms] [3]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Chris Dumez 2018-03-30 13:03:15 PDT
Created attachment 336881 [details]
Patch
Comment 11 EWS Watchlist 2018-03-30 13:05:32 PDT
Attachment 336881 [details] did not pass style-queue:


ERROR: Source/WebKit/ChangeLog:10:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: security bug  [changelog/unwantedsecurityterms] [3]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 EWS Watchlist 2018-03-30 14:11:14 PDT
Comment on attachment 336881 [details]
Patch

Attachment 336881 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7151306

New failing tests:
plugins/npp-set-window-called-during-destruction.html
Comment 13 EWS Watchlist 2018-03-30 14:11:15 PDT
Created attachment 336886 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 14 Chris Dumez 2018-04-05 08:19:28 PDT
Created attachment 337263 [details]
Patch
Comment 15 EWS Watchlist 2018-04-05 08:20:59 PDT
Attachment 337263 [details] did not pass style-queue:


ERROR: Source/WebKit/ChangeLog:10:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: security bug  [changelog/unwantedsecurityterms] [3]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 16 EWS Watchlist 2018-04-05 09:30:38 PDT
Comment on attachment 337263 [details]
Patch

Attachment 337263 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7215713

New failing tests:
plugins/npp-set-window-called-during-destruction.html
Comment 17 EWS Watchlist 2018-04-05 09:30:39 PDT
Created attachment 337268 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 18 Chris Dumez 2018-09-25 15:21:57 PDT
Created attachment 350800 [details]
WIP Patch
Comment 19 Chris Dumez 2018-09-25 15:26:38 PDT
Created attachment 350801 [details]
WIP Patch
Comment 20 Chris Dumez 2018-09-25 16:46:32 PDT
Created attachment 350810 [details]
WIP Patch
Comment 21 EWS Watchlist 2018-09-25 18:04:24 PDT
Comment on attachment 350810 [details]
WIP Patch

Attachment 350810 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9350431

New failing tests:
fast/frames/flattening/iframe-tiny.html
js/dom/math-random-initial-values.html
Comment 22 EWS Watchlist 2018-09-25 18:04:26 PDT
Created attachment 350822 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 23 EWS Watchlist 2018-09-25 18:59:59 PDT
Comment on attachment 350810 [details]
WIP Patch

Attachment 350810 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9350557

New failing tests:
http/tests/misc/bad-charset-alias.html
http/tests/misc/dns-prefetch-control.html
Comment 24 EWS Watchlist 2018-09-25 19:00:01 PDT
Created attachment 350831 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 25 EWS Watchlist 2018-09-25 20:45:27 PDT
Comment on attachment 350810 [details]
WIP Patch

Attachment 350810 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9351478

New failing tests:
editing/undo/remove-css-property-and-remove-style.html
editing/undo/redo-split-text-node.html
editing/undo/4063751.html
editing/pasteboard/undoable-fragment-removes.html
editing/undo/undo-after-setting-value.html
editing/execCommand/delete-selection-has-style.html
editing/deleting/delete-and-undo.html
editing/undo/replace-by-span-then-remove.html
editing/deleting/paragraph-in-preserveNewline.html
editing/inserting/redo.html
editing/undo/redo-split-text-with-removal.html
editing/style/stylewithcss-without-selection.html
editing/deleting/whitespace-pre-1.html
editing/execCommand/format-block-multiple-paragraphs-in-pre.html
Comment 26 EWS Watchlist 2018-09-25 20:45:31 PDT
Created attachment 350842 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 27 Chris Dumez 2018-09-26 11:47:15 PDT
Created attachment 350875 [details]
WIP Patch
Comment 28 EWS Watchlist 2018-09-26 13:12:25 PDT
Comment on attachment 350875 [details]
WIP Patch

Attachment 350875 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9358667

New failing tests:
editing/pasteboard/emacs-ctrl-a-k-y.html
Comment 29 EWS Watchlist 2018-09-26 13:12:27 PDT
Created attachment 350890 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 30 Chris Dumez 2018-09-26 13:51:00 PDT
Created attachment 350897 [details]
Patch
Comment 31 Chris Dumez 2018-09-26 15:19:14 PDT
Created attachment 350914 [details]
Patch
Comment 32 Ryosuke Niwa 2018-09-26 18:53:30 PDT
Comment on attachment 350914 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350914&action=review

> Source/WebKit/ChangeLog:16
> +        IPC while waiting for a a synchronous IPC reply, expect in cases where it would cause a deadlock.

waiting for "a a"

> Source/WebKit/ChangeLog:18
> +        As a result, this patch also dropts support for the DoNotProcessIncomingMessagesWhenWaitingForSyncReply

drop*t*s
Comment 33 Chris Dumez 2018-09-27 08:57:13 PDT
Committed r236546: <https://trac.webkit.org/changeset/236546>