RESOLVED FIXED 184175
Add pointer profiling support to Wasm. 
https://bugs.webkit.org/show_bug.cgi?id=184175
Summary Add pointer profiling support to Wasm.
Mark Lam
Reported 2018-03-29 22:43:36 PDT
Patch coming.
Attachments
proposed patch. (28.92 KB, patch)
2018-03-29 23:01 PDT, Mark Lam 		jfbastien: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-03-29 22:44:13 PDT
<rdar://problem/39027923>
Mark Lam
Comment 2 2018-03-29 23:01:46 PDT
Created attachment 336842 [details] proposed patch.
JF Bastien
Comment 3 2018-03-30 08:46:57 PDT
Comment on attachment 336842 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=336842&action=review r=me this is great! :D > Source/JavaScriptCore/wasm/js/WebAssemblyFunction.h:72 > + return m_jsEntrypoint.retagged(CodeEntryPtrTag, CodeEntryWithArityCheckPtrTag); Right now vmEntryToWebAssembly is the same thing as vmEntryToJavaScript. Should we split them and use different CodeEntryPtrTag?
Mark Lam
Comment 4 2018-03-30 09:26:54 PDT
Comment on attachment 336842 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=336842&action=review Thanks for the review. >> Source/JavaScriptCore/wasm/js/WebAssemblyFunction.h:72 >> + return m_jsEntrypoint.retagged(CodeEntryPtrTag, CodeEntryWithArityCheckPtrTag); > > Right now vmEntryToWebAssembly is the same thing as vmEntryToJavaScript. Should we split them and use different CodeEntryPtrTag? Let's only make a change when the need arises later.
Mark Lam
Comment 5 2018-03-30 09:32:52 PDT
Landed in r230106: <http://trac.webkit.org/r230106>.
Note You need to log in before you can comment on or make changes to this bug.