Bug 184172 - Use Forward.h instead of forward-declaring WTF::String
Summary: Use Forward.h instead of forward-declaring WTF::String
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: JF Bastien
URL:
Keywords: InRadar
Depends on:
Blocks: 184164 184179
  Show dependency tree / graph
 
Reported: 2018-03-29 21:12 PDT by JF Bastien
Modified: 2018-03-30 09:06 PDT (History)
6 users (show)

See Also:

Attachments
patch (18.27 KB, patch)
2018-03-29 21:16 PDT, JF Bastien 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description JF Bastien 2018-03-29 21:12:11 PDT 
As part of #184164 I'm changing WTF::String, and the forward declarations are just wrong because I'm making it templated. We should use Forward.h anyways, so do that instead.
Comment 1 Radar WebKit Bug Importer 2018-03-29 21:12:42 PDT 
<rdar://problem/39026146>
Comment 2 JF Bastien 2018-03-29 21:16:56 PDT 
Created attachment 336839 [details]
patch
Comment 3 EWS Watchlist 2018-03-29 21:18:47 PDT 
Attachment 336839 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/PrintStream.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/ios/Device.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Yusuke Suzuki 2018-03-29 21:39:13 PDT 
Comment on attachment 336839 [details]
patch

r=me
Comment 5 WebKit Commit Bot 2018-03-29 22:05:20 PDT 
Comment on attachment 336839 [details]
patch

Clearing flags on attachment: 336839

Committed r230097: <https://trac.webkit.org/changeset/230097>
Comment 6 WebKit Commit Bot 2018-03-29 22:05:22 PDT 
All reviewed patches have been landed.  Closing bug.