WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
184170
Remove WTF_EXPORTDATA and JS_EXPORTDATA
https://bugs.webkit.org/show_bug.cgi?id=184170
Summary
Remove WTF_EXPORTDATA and JS_EXPORTDATA
Yusuke Suzuki
Reported
2018-03-29 19:44:43 PDT
Remove WTF_EXPORTDATA and JS_EXPORTDATA
Attachments
Patch
(18.97 KB, patch)
2018-03-29 19:45 PDT
,
Yusuke Suzuki
jfbastien
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1
2018-03-29 19:45:53 PDT
Created
attachment 336833
[details]
Patch
JF Bastien
Comment 2
2018-03-29 19:52:45 PDT
Comment on
attachment 336833
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=336833&action=review
Hehe I was going to do that next :) r=me with a tiny nit.
> Source/JavaScriptCore/runtime/JSCell.h:73 > + static JS_EXPORT_PRIVATE const ::JSC::ClassInfo s_info; \
Messed up alignment here :)
Yusuke Suzuki
Comment 3
2018-03-29 21:15:08 PDT
Comment on
attachment 336833
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=336833&action=review
>> Source/JavaScriptCore/runtime/JSCell.h:73 >> + static JS_EXPORT_PRIVATE const ::JSC::ClassInfo s_info; \ > > Messed up alignment here :)
Nice, fixed.
Yusuke Suzuki
Comment 4
2018-03-29 21:16:35 PDT
Committed
r230092
: <
https://trac.webkit.org/changeset/230092
>
Radar WebKit Bug Importer
Comment 5
2018-03-29 21:17:20 PDT
<
rdar://problem/39026266
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug