Bug 184170 - Remove WTF_EXPORTDATA and JS_EXPORTDATA
Summary: Remove WTF_EXPORTDATA and JS_EXPORTDATA
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-29 19:44 PDT by Yusuke Suzuki
Modified: 2018-03-29 21:17 PDT (History)
12 users (show)

See Also:

Attachments
Patch (18.97 KB, patch)
2018-03-29 19:45 PDT, Yusuke Suzuki 		jfbastien: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-03-29 19:44:43 PDT 
Remove WTF_EXPORTDATA and JS_EXPORTDATA
Comment 1 Yusuke Suzuki 2018-03-29 19:45:53 PDT 
Created attachment 336833 [details]
Patch
Comment 2 JF Bastien 2018-03-29 19:52:45 PDT 
Comment on attachment 336833 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336833&action=review

Hehe I was going to do that next :)
r=me with a tiny nit.

> Source/JavaScriptCore/runtime/JSCell.h:73
> +        static JS_EXPORT_PRIVATE const ::JSC::ClassInfo s_info;                  \

Messed up alignment here :)
Comment 3 Yusuke Suzuki 2018-03-29 21:15:08 PDT 
Comment on attachment 336833 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336833&action=review

>> Source/JavaScriptCore/runtime/JSCell.h:73
>> +        static JS_EXPORT_PRIVATE const ::JSC::ClassInfo s_info;                  \
> 
> Messed up alignment here :)

Nice, fixed.
Comment 4 Yusuke Suzuki 2018-03-29 21:16:35 PDT 
Committed r230092: <https://trac.webkit.org/changeset/230092>
Comment 5 Radar WebKit Bug Importer 2018-03-29 21:17:20 PDT 
<rdar://problem/39026266>