Bug 184162 - Followup(r230063): Add test a layout test for https://bugs.webkit.org/show_bug.cgi?id=183972
Summary: Followup(r230063): Add test a layout test for https://bugs.webkit.org/show_bu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on: 183972
Blocks:
  Show dependency tree / graph
 
Reported: 2018-03-29 16:13 PDT by Said Abou-Hallawa
Modified: 2018-04-02 14:52 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.78 KB, patch)
2018-03-29 16:16 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (3.75 KB, patch)
2018-03-30 07:45 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2018-03-29 16:13:51 PDT 
I wrote a layout test for https://bugs.webkit.org/show_bug.cgi?id=183972 and I spent some time trying to get it to crash without the patch. But I could not get the test to crash so I went ahead and I landed r230063. I then realized it is actually worthy to add such test to ensure the SVG tear-off objects are more robust.
Comment 1 Said Abou-Hallawa 2018-03-29 16:16:49 PDT 
Created attachment 336816 [details]
Patch
Comment 2 Said Abou-Hallawa 2018-03-30 07:45:04 PDT 
Created attachment 336853 [details]
Patch
Comment 3 Ryan Haddad 2018-03-31 14:09:06 PDT 
I'm not sure why this patch is still stuck waiting for EWS. I released all the locks and resubmitted it, but apparently that didn't help.
Comment 4 Daniel Bates 2018-04-02 10:27:23 PDT 
Comment on attachment 336853 [details]
Patch

Thanks for taking the time to write a test! r=me
Comment 5 Said Abou-Hallawa 2018-04-02 12:42:44 PDT 
Committed r230172: <https://trac.webkit.org/changeset/230172>
Comment 6 Radar WebKit Bug Importer 2018-04-02 12:43:35 PDT 
<rdar://problem/39114918>
Comment 7 Aakash Jain 2018-04-02 14:52:46 PDT 
(In reply to Ryan Haddad from comment #3)
> I'm not sure why this patch is still stuck waiting for EWS. I released all
> the locks and resubmitted it, but apparently that didn't help.

This is hitting https://bugs.webkit.org/show_bug.cgi?id=171463  (<rdar://problem/31894087>).

The issue is that the bug title contains another bug id which confuses EWS.