Bug 184137 - ArrayMode should not try to get the DFG to think it can convert TypedArrays
Summary: ArrayMode should not try to get the DFG to think it can convert TypedArrays
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-29 09:48 PDT by Keith Miller
Modified: 2018-03-29 12:10 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.80 KB, patch)
2018-03-29 09:52 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (1.79 KB, patch)
2018-03-29 10:17 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2018-03-29 09:48:28 PDT 
ArrayMode should not try to get the DFG to think it can convert TypedArrays
Comment 1 Keith Miller 2018-03-29 09:52:33 PDT 
Created attachment 336779 [details]
Patch
Comment 2 Saam Barati 2018-03-29 09:54:45 PDT 
Comment on attachment 336779 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336779&action=review

maybe add a microbenchmark?

> Source/JavaScriptCore/dfg/DFGArrayMode.cpp:121
> +        // If we have seen multiple TypedArray types or a TypedArray and non-typed array it doesn't make sense to try to convert the array since we won't be able to when we have a typed array.

"If we have seen multiple TypedArray types or a TypedArray and non-typed array it doesn't make sense to try to convert the array since we won't be able to when we have a typed array." =>
"If we have seen multiple TypedArray types, or a TypedArray and non-typed array, it doesn't make sense to try to convert the array since you can't convert typed arrays."
Comment 3 Keith Miller 2018-03-29 10:17:13 PDT 
Created attachment 336782 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2018-03-29 12:09:05 PDT 
Comment on attachment 336782 [details]
Patch for landing

Clearing flags on attachment: 336782

Committed r230078: <https://trac.webkit.org/changeset/230078>
Comment 5 WebKit Commit Bot 2018-03-29 12:09:07 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-03-29 12:10:22 PDT 
<rdar://problem/39008430>