Bug 184119 - [GTK] DragAndDropHandler.cpp should include GUniquePtrGtk.h
Summary: [GTK] DragAndDropHandler.cpp should include GUniquePtrGtk.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-28 17:13 PDT by Michael Catanzaro
Modified: 2018-04-02 07:42 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.38 KB, patch)
2018-03-28 17:13 PDT, Michael Catanzaro
dbates: review+
cgarcia: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-03-28 17:13:00 PDT
We've failed to figure out why, but in some build configurations, GUniquePtrGtk.h doesn't get pulled in and the unique_ptrs use the wrong deleter function. This file should include what it needs.
Comment 1 Michael Catanzaro 2018-03-28 17:13:45 PDT
Created attachment 336736 [details]
Patch
Comment 2 Daniel Bates 2018-03-28 23:35:44 PDT
Comment on attachment 336736 [details]
Patch

OK
Comment 3 Carlos Garcia Campos 2018-04-02 00:45:38 PDT
Comment on attachment 336736 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336736&action=review

> Source/WebKit/UIProcess/gtk/DragAndDropHandler.cpp:31
> +#include "GUniquePtrGtk.h"

This is a WebCoire header included in WebKLit layer, please use <WebCore/GUniquePtrGtk.h> instead.
Comment 4 Michael Catanzaro 2018-04-02 07:29:00 PDT
Whoops, must have gotten confused. And also forgot about this.
Comment 5 Michael Catanzaro 2018-04-02 07:29:52 PDT
Actually this tells me we have a bug with our include paths: that really should not have compiled at all. :/
Comment 6 Michael Catanzaro 2018-04-02 07:30:19 PDT
(In reply to Michael Catanzaro from comment #5)
> Actually this tells me we have a bug with our include paths: that really
> should not have compiled at all. :/

I guess it's because we use PUBLIC include directories everywhere. CMake is wonderful that way....
Comment 7 Michael Catanzaro 2018-04-02 07:42:39 PDT
Committed r230156: <https://trac.webkit.org/changeset/230156>