Bug 184117 - run-jsc-benchmarks should recognize Windows-style build directory structure.
Summary: run-jsc-benchmarks should recognize Windows-style build directory structure.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-28 16:38 PDT by Ross Kirsling
Modified: 2018-03-29 21:36 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.90 KB, patch)
2018-03-28 16:39 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch for landing (1.88 KB, patch)
2018-03-29 20:10 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2018-03-28 16:38:54 PDT 
run-jsc-benchmarks should recognize Windows-style build directory structure.
Comment 1 Ross Kirsling 2018-03-28 16:39:43 PDT 
Created attachment 336733 [details]
Patch
Comment 2 Yusuke Suzuki 2018-03-29 19:04:10 PDT 
Comment on attachment 336733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336733&action=review

r=me with some nits

> Tools/Scripts/run-jsc-benchmarks:1345
> +    elsif @path =~ /\/Release\/bin(64|32|)\/([.a-zA-Z]+)$/

I think `[.a-zA-Z]` should be `[\.a-zA-Z]`.

> Tools/Scripts/run-jsc-benchmarks:1347
> +    elsif @path =~ /\/Debug\/bin(64|32|)\/([.a-zA-Z]+)$/

Ditto.
Comment 3 Ross Kirsling 2018-03-29 20:10:37 PDT 
Created attachment 336835 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2018-03-29 21:35:12 PDT 
Comment on attachment 336835 [details]
Patch for landing

Clearing flags on attachment: 336835

Committed r230093: <https://trac.webkit.org/changeset/230093>
Comment 5 WebKit Commit Bot 2018-03-29 21:35:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-03-29 21:36:21 PDT 
<rdar://problem/39026716>