184114 – NetworkResourceLoader does not need to expose all redirect response headers

RESOLVED FIXED 184114

NetworkResourceLoader does not need to expose all redirect response headers

https://bugs.webkit.org/show_bug.cgi?id=184114

Summary NetworkResourceLoader does not need to expose all redirect response headers

youenn fablet

Reported 2018-03-28 15:17:48 PDT

Some headers are not used by WebContent processes although they may be leaked to JavaScript.

Attachments
Patch (8.83 KB, patch) 2018-03-28 17:08 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (8.88 KB, patch) 2018-03-29 13:29 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (28.52 KB, patch) 2018-04-02 10:15 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-sierra (2.31 MB, application/zip) 2018-04-02 11:30 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews115 for mac-sierra (3.20 MB, application/zip) 2018-04-02 12:54 PDT, EWS Watchlist	no flags	Details
Patch (27.44 KB, patch) 2018-04-02 13:47 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews205 for win-future (12.14 MB, application/zip) 2018-04-02 18:35 PDT, EWS Watchlist	no flags	Details
Patch for landing (29.54 KB, patch) 2018-04-03 14:17 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2018-03-28 17:08:52 PDT

Created attachment 336735 [details] Patch

Radar WebKit Bug Importer

Comment 2 2018-03-29 13:03:35 PDT

<rdar://problem/39010557>

youenn fablet

Comment 3 2018-03-29 13:29:38 PDT

Created attachment 336801 [details] Patch

youenn fablet

Comment 4 2018-04-02 10:15:55 PDT

Created attachment 336994 [details] Patch

youenn fablet

Comment 5 2018-04-02 11:08:16 PDT

I forgot to skip http/wpt/loading/redirect-headers.html in WK1 since this is a WK2 only test...

EWS Watchlist

Comment 6 2018-04-02 11:30:19 PDT

Comment on attachment 336994 [details] Patch Attachment 336994 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7179651 New failing tests: http/wpt/loading/redirect-headers.html

EWS Watchlist

Comment 7 2018-04-02 11:30:20 PDT

Created attachment 337005 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 8 2018-04-02 12:54:33 PDT

Comment on attachment 336994 [details] Patch Attachment 336994 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7180997 New failing tests: http/wpt/loading/redirect-headers.html

EWS Watchlist

Comment 9 2018-04-02 12:54:34 PDT

Created attachment 337015 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6

youenn fablet

Comment 10 2018-04-02 13:47:59 PDT

Created attachment 337025 [details] Patch

youenn fablet

Comment 11 2018-04-02 13:52:51 PDT

(In reply to youenn fablet from comment #10) > Created attachment 337025 [details] > Patch Skipping new test for WK1 that does not implement response header filtering

EWS Watchlist

Comment 12 2018-04-02 18:35:34 PDT

Comment on attachment 337025 [details] Patch Attachment 337025 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7186253 New failing tests: http/wpt/loading/redirect-headers.html

EWS Watchlist

Comment 13 2018-04-02 18:35:45 PDT

Created attachment 337049 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

youenn fablet

Comment 14 2018-04-03 14:17:12 PDT

Created attachment 337114 [details] Patch for landing

WebKit Commit Bot

Comment 15 2018-04-03 15:20:27 PDT

Comment on attachment 337114 [details] Patch for landing Clearing flags on attachment: 337114 Committed r230224: <https://trac.webkit.org/changeset/230224>

WebKit Commit Bot

Comment 16 2018-04-03 15:20:28 PDT

All reviewed patches have been landed. Closing bug.

Ryan Haddad

Comment 17 2018-04-04 14:02:39 PDT

The LayoutTest added with this change is a flaky failure on macOS: --- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/http/wpt/loading/redirect-headers-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/http/wpt/loading/redirect-headers-actual.txt @@ -7,5 +7,4 @@ http://localhost:8800/WebKit/loading/redirect-headers.html - didFinishLoading http://localhost:8800/WebKit/beacon/resources/redirect.py?status=302&location=/ - willSendRequest <NSURLRequest URL http://localhost:8800/?status=302&location=%2F&count=1, main document URL http://localhost:8800/WebKit/loading/redirect-headers.html, http method GET> redirectResponse <NSURLResponse http://localhost:8800/WebKit/beacon/resources/redirect.py?status=302&location=/, http status code 302, 6 headers> http://localhost:8800/WebKit/beacon/resources/redirect.py?status=302&location=/ - didReceiveResponse <NSURLResponse http://localhost:8800/?status=302&location=%2F&count=1, http status code 200> -http://localhost:8800/WebKit/beacon/resources/redirect.py?status=302&location=/ - didFinishLoading https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Floading%2Fredirect-headers.html

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component WebCore Misc.

Assignee

youenn fablet

Reported

2018-03-28 15:17 PDT

Modified

2018-04-04 14:02 PDT History

CC List

8 users Show

URL

Keywords InRadar

Depends on

Blocks