Bug 184113 - The 'text' color keyword is not considered a system color
Summary: The 'text' color keyword is not considered a system color
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-28 15:12 PDT by Timothy Hatcher
Modified: 2018-03-28 17:02 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2018-03-28 15:23 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2018-03-28 15:12:17 PDT 
RenderTheme considers CSSValueText a system color, but it never gets consulted.
Comment 1 Timothy Hatcher 2018-03-28 15:12:33 PDT 
<rdar://problem/38779267>
Comment 2 Timothy Hatcher 2018-03-28 15:23:14 PDT 
Created attachment 336726 [details]
Patch
Comment 3 Tim Horton 2018-03-28 15:25:21 PDT 
Comment on attachment 336726 [details]
Patch

Ideally this would have a test.
Comment 4 WebKit Commit Bot 2018-03-28 15:50:50 PDT 
Comment on attachment 336726 [details]
Patch

Clearing flags on attachment: 336726

Committed r230056: <https://trac.webkit.org/changeset/230056>
Comment 5 WebKit Commit Bot 2018-03-28 15:50:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Simon Fraser (smfr) 2018-03-28 16:09:21 PDT 
Can we add a test please?
Comment 7 Timothy Hatcher 2018-03-28 16:38:57 PDT 
(In reply to Simon Fraser (smfr) from comment #6)
> Can we add a test please?

I'll look at adding tests for another bug I have tracking this work.