Drop DOMWindow::frames() / DOMWindow::window() methods as they are just aliases for DOMWindow::self().
Created attachment 336724 [details] Patch
Comment on attachment 336724 [details] Patch r=me
Comment on attachment 336724 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336724&action=review > Source/WebCore/page/DOMWindow.h:194 > // Self-referential attributes Please remove this comment now that self() is the only self-referential attribute that we have a member function for and its name is self-descriptive. Self :)
(In reply to Daniel Bates from comment #3) > Comment on attachment 336724 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=336724&action=review > > > Source/WebCore/page/DOMWindow.h:194 > > // Self-referential attributes > > Please remove this comment now that self() is the only self-referential > attribute that we have a member function for and its name is > self-descriptive. Self :) Err, top() is self-referential for the main frame :/
Created attachment 336777 [details] Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment on attachment 336777 [details] Patch Clearing flags on attachment: 336777 Committed r230077: <https://trac.webkit.org/changeset/230077>
All reviewed patches have been landed. Closing bug.
<rdar://problem/39002370>