Bug 184093 - Rename UNUSED to BUNUSED
Summary: Rename UNUSED to BUNUSED
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-28 09:58 PDT by Michael Catanzaro
Modified: 2018-04-09 18:43 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.22 KB, patch)
2018-03-28 09:58 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
Patch (3.65 KB, patch)
2018-03-28 17:32 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-03-28 09:58:07 PDT 
Should we rename UNUSED to BUNUSED? This would make it less likely to be misused outside of bmalloc, as I did in bug #184081.
Comment 1 Michael Catanzaro 2018-03-28 09:58:55 PDT 
Created attachment 336669 [details]
Patch
Comment 2 Michael Catanzaro 2018-03-28 17:32:01 PDT 
Created attachment 336738 [details]
Patch
Comment 3 Michael Catanzaro 2018-04-09 17:28:19 PDT 
Pinging bmalloc reviewers!
Comment 4 Yusuke Suzuki 2018-04-09 17:32:19 PDT 
Comment on attachment 336738 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336738&action=review

r=me

> Source/bmalloc/bmalloc/BAssert.h:103
> +#define BUNUSED(x) ((void)x)

renaming this to `BUNUSED_PARAM` would be good. But either is OK to me.
Comment 5 Michael Catanzaro 2018-04-09 18:12:44 PDT 
Comment on attachment 336738 [details]
Patch

I kinda prefer BUNUSED, it's short and sweet, but no strong preference here either. Whatever the bmalloc crew prefers.
Comment 6 WebKit Commit Bot 2018-04-09 18:42:50 PDT 
Comment on attachment 336738 [details]
Patch

Clearing flags on attachment: 336738

Committed r230463: <https://trac.webkit.org/changeset/230463>
Comment 7 WebKit Commit Bot 2018-04-09 18:42:52 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-04-09 18:43:20 PDT 
<rdar://problem/39301964>