Bug 184092 - [Extra zoom mode] Make boosted text autosizing values switchable at runtime
Summary: [Extra zoom mode] Make boosted text autosizing values switchable at runtime
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-28 09:42 PDT by Wenson Hsieh
Modified: 2018-03-28 11:55 PDT (History)
6 users (show)

See Also:

Attachments
Patch (20.25 KB, patch)
2018-03-28 10:49 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-03-28 09:42:32 PDT 
<rdar://problem/38939917>
Comment 1 Wenson Hsieh 2018-03-28 10:49:04 PDT 
Created attachment 336675 [details]
Patch
Comment 2 Wenson Hsieh 2018-03-28 10:55:26 PDT 
Comment on attachment 336675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336675&action=review

> Source/WebKit/ChangeLog:10
> +        normal text autosizing values.

...or, maybe we should be using boosted text autosizing in extra zoom mode instead? Not quite sure, but it's a small tweak regardless.
Comment 3 Wenson Hsieh 2018-03-28 11:30:35 PDT 
Comment on attachment 336675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336675&action=review

Thanks for the review!

>> Source/WebKit/ChangeLog:10
>> +        normal text autosizing values.
> 
> ...or, maybe we should be using boosted text autosizing in extra zoom mode instead? Not quite sure, but it's a small tweak regardless.

Let's keep text autosizing constants normal (non-boosted) by default for now.
Comment 4 WebKit Commit Bot 2018-03-28 11:55:45 PDT 
Comment on attachment 336675 [details]
Patch

Clearing flags on attachment: 336675

Committed r230039: <https://trac.webkit.org/changeset/230039>
Comment 5 WebKit Commit Bot 2018-03-28 11:55:46 PDT 
All reviewed patches have been landed.  Closing bug.