RESOLVED FIXED 184089
[DFG] More aggressive removal of duplicate 32bit DFG code 
https://bugs.webkit.org/show_bug.cgi?id=184089
Summary [DFG] More aggressive removal of duplicate 32bit DFG code
Yusuke Suzuki
Reported 2018-03-28 09:12:50 PDT
[DFG] More aggressive removal of 32bit DFG
Attachments
Patch (69.17 KB, patch)
2018-03-28 09:13 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (69.24 KB, patch)
2018-03-28 19:23 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (69.25 KB, patch)
2018-03-28 19:28 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (69.37 KB, patch)
2018-03-29 19:18 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-03-28 09:13:41 PDT
Created attachment 336662 [details] Patch
Saam Barati
Comment 2 2018-03-28 11:44:20 PDT
Comment on attachment 336662 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336662&action=review seems like you broke 32-bit x86 builds > Source/JavaScriptCore/ChangeLog:3 > + [DFG] More aggressive removal of 32bit DFG this title should have "duplicate" before "32bit"
Yusuke Suzuki
Comment 3 2018-03-28 19:23:01 PDT
Created attachment 336746 [details] Patch
Yusuke Suzuki
Comment 4 2018-03-28 19:27:54 PDT
OK, updated
Yusuke Suzuki
Comment 5 2018-03-28 19:28:50 PDT
Created attachment 336748 [details] Patch
Yusuke Suzuki
Comment 6 2018-03-29 19:18:58 PDT
Created attachment 336832 [details] Patch
Yusuke Suzuki
Comment 7 2018-03-29 22:40:43 PDT
Ping?
Saam Barati
Comment 8 2018-04-01 18:23:46 PDT
Comment on attachment 336832 [details] Patch LGTM
Yusuke Suzuki
Comment 9 2018-04-02 00:25:53 PDT
Comment on attachment 336832 [details] Patch Thanks
WebKit Commit Bot
Comment 10 2018-04-02 00:51:21 PDT
Comment on attachment 336832 [details] Patch Clearing flags on attachment: 336832 Committed r230150: <https://trac.webkit.org/changeset/230150>
WebKit Commit Bot
Comment 11 2018-04-02 00:51:23 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2018-04-02 00:52:19 PDT
<rdar://problem/39098832>
Note You need to log in before you can comment on or make changes to this bug.