Bug 184089 - [DFG] More aggressive removal of duplicate 32bit DFG code
Summary: [DFG] More aggressive removal of duplicate 32bit DFG code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-28 09:12 PDT by Yusuke Suzuki
Modified: 2018-04-02 00:52 PDT (History)
10 users (show)

See Also:

Attachments
Patch (69.17 KB, patch)
2018-03-28 09:13 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (69.24 KB, patch)
2018-03-28 19:23 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (69.25 KB, patch)
2018-03-28 19:28 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (69.37 KB, patch)
2018-03-29 19:18 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-03-28 09:12:50 PDT 
[DFG] More aggressive removal of 32bit DFG
Comment 1 Yusuke Suzuki 2018-03-28 09:13:41 PDT 
Created attachment 336662 [details]
Patch
Comment 2 Saam Barati 2018-03-28 11:44:20 PDT 
Comment on attachment 336662 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336662&action=review

seems like you broke 32-bit x86 builds

> Source/JavaScriptCore/ChangeLog:3
> +        [DFG] More aggressive removal of 32bit DFG

this title should have "duplicate" before "32bit"
Comment 3 Yusuke Suzuki 2018-03-28 19:23:01 PDT 
Created attachment 336746 [details]
Patch
Comment 4 Yusuke Suzuki 2018-03-28 19:27:54 PDT 
OK, updated
Comment 5 Yusuke Suzuki 2018-03-28 19:28:50 PDT 
Created attachment 336748 [details]
Patch
Comment 6 Yusuke Suzuki 2018-03-29 19:18:58 PDT 
Created attachment 336832 [details]
Patch
Comment 7 Yusuke Suzuki 2018-03-29 22:40:43 PDT 
Ping?
Comment 8 Saam Barati 2018-04-01 18:23:46 PDT 
Comment on attachment 336832 [details]
Patch

LGTM
Comment 9 Yusuke Suzuki 2018-04-02 00:25:53 PDT 
Comment on attachment 336832 [details]
Patch

Thanks
Comment 10 WebKit Commit Bot 2018-04-02 00:51:21 PDT 
Comment on attachment 336832 [details]
Patch

Clearing flags on attachment: 336832

Committed r230150: <https://trac.webkit.org/changeset/230150>
Comment 11 WebKit Commit Bot 2018-04-02 00:51:23 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2018-04-02 00:52:19 PDT 
<rdar://problem/39098832>