Bug 184069 - Enhance ARM64 probe to support pointer profiling.
Summary: Enhance ARM64 probe to support pointer profiling.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-27 19:36 PDT by Mark Lam
Modified: 2018-03-28 13:06 PDT (History)
7 users (show)

See Also:


Attachments
proposed patch. (6.88 KB, patch)
2018-03-27 19:42 PDT, Mark Lam
jfbastien: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-03-27 19:36:46 PDT
Patch coming.
Comment 1 Radar WebKit Bug Importer 2018-03-27 19:38:51 PDT
<rdar://problem/38939879>
Comment 2 Mark Lam 2018-03-27 19:42:53 PDT
Created attachment 336639 [details]
proposed patch.
Comment 3 JF Bastien 2018-03-27 21:37:28 PDT
Comment on attachment 336639 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=336639&action=review

r=me

> Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:2146
> +    }

Assert that the registers aren't the same?
Comment 4 Mark Lam 2018-03-28 13:04:10 PDT
(In reply to JF Bastien from comment #3)
> > Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:2146
> > +    }
> 
> Assert that the registers aren't the same?

We talked offline, and concluded that this assertion is not always true.  The client is allowed to push the same register twice if desired.  So, we'll not add the assert.
Comment 5 Mark Lam 2018-03-28 13:06:21 PDT
Thanks for the review.  Landed in r230040: <http://trac.webkit.org/r230040>.