The existing logging code for cookie reads/writes, partitioning, and blocking was not getting hit for various test cases. This patch revises the logging slightly so that we get more consistent logging during test passes.
<rdar://problem/38915610>
Created attachment 336594 [details] Patch
Comment on attachment 336594 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336594&action=review > Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:743 > +static String escapeIDForJSON(std::optional<uint64_t> value) I would use a const & here. > Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:840 > +void NetworkResourceLoader::logCookieInformation(const String& label, const void* loggedObject, const WebCore::NetworkStorageSession& networkStorageSession, const WebCore::URL& firstParty, const WebCore::URL& url, const String& referrer, std::optional<uint64_t> frameID, std::optional<uint64_t> pageID, std::optional<uint64_t> identifier) WebCore:: is not needed. > Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:847 > + auto partition = WebCore::URL(ParsedURLString, networkStorageSession.cookieStoragePartition(firstParty, url, frameID, pageID)); WebCore:: is not needed.
I'll fix the debug issue when landing.
Committed r230002: <https://trac.webkit.org/changeset/230002>