Bug 184042 - [GTK][WPE] Remove UpdateAtlas
Summary: [GTK][WPE] Remove UpdateAtlas
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Miguel Gomez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-27 08:12 PDT by Miguel Gomez
Modified: 2018-03-28 05:30 PDT (History)
3 users (show)

See Also:


Attachments
Patch (52.97 KB, patch)
2018-03-27 08:22 PDT, Miguel Gomez
no flags Details | Formatted Diff | Diff
Patch (56.87 KB, patch)
2018-03-28 03:33 PDT, Miguel Gomez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2018-03-27 08:12:07 PDT
Stop using UpdateAtlas as a cache of buffers to draw cairo content, and allocate new buffers each time instead.
Comment 1 Miguel Gomez 2018-03-27 08:22:00 PDT
Created attachment 336587 [details]
Patch
Comment 2 Zan Dobersek 2018-03-27 12:38:52 PDT
Comment on attachment 336587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336587&action=review

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:984
> +            updateInfo.surfaceOffset = {0, 0};

This can be more spacious: 'surfaceOffset = { 0, 0 };

Or better yet, it can be removed, perhaps in a separate patch.

> Source/WebKit/WebProcess/WebPage/AcceleratedDrawingArea.h:78
> +    void resetUpdateAtlasForTesting() override { };

Can we remove this as well? It's specific to coordgraphics.
Comment 3 Miguel Gomez 2018-03-28 03:33:38 PDT
Created attachment 336650 [details]
Patch
Comment 4 WebKit Commit Bot 2018-03-28 05:30:15 PDT
Comment on attachment 336650 [details]
Patch

Clearing flags on attachment: 336650

Committed r230028: <https://trac.webkit.org/changeset/230028>
Comment 5 WebKit Commit Bot 2018-03-28 05:30:17 PDT
All reviewed patches have been landed.  Closing bug.