Bug 184035 - [GStreamer] Enhance debugging in the BasePlayer
Summary: [GStreamer] Enhance debugging in the BasePlayer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-27 05:59 PDT by Thibault Saunier
Modified: 2018-03-27 09:26 PDT (History)
3 users (show)

See Also:


Attachments
Patch (13.74 KB, patch)
2018-03-27 06:04 PDT, Thibault Saunier
no flags Details | Formatted Diff | Diff
Patch (15.43 KB, patch)
2018-03-27 06:21 PDT, Thibault Saunier
no flags Details | Formatted Diff | Diff
Patch (15.44 KB, patch)
2018-03-27 08:43 PDT, Thibault Saunier
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Saunier 2018-03-27 05:59:58 PDT
[GStreamer] Enhance debugging in the BasePlayer
Comment 1 Thibault Saunier 2018-03-27 06:04:22 PDT
Created attachment 336574 [details]
Patch
Comment 2 Thibault Saunier 2018-03-27 06:21:46 PDT
Created attachment 336575 [details]
Patch
Comment 3 Philippe Normand 2018-03-27 07:41:15 PDT
Broke WPE build:


/home/ews/igalia-wpe-ews/WebKit/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp: In lambda function:
/home/ews/igalia-wpe-ews/WebKit/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:384:39: error: ‘this’ was not captured for this lambda function
             GST_DEBUG_OBJECT(pipeline(), "scheduling initializationDataEncountered event for %s with concatenated init datas size of %" G_GSIZE_FORMAT, eventKeySystemIdString.utf8().data(), initData.size());
                                       ^
/home/ews/igalia-wpe-ews/WebKit/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:384:39: error: cannot call member function ‘GstElement* WebCore::MediaPlayerPrivateGStreamerBase::pipeline() const’ without object
Comment 4 Thibault Saunier 2018-03-27 08:43:44 PDT
Created attachment 336589 [details]
Patch
Comment 5 WebKit Commit Bot 2018-03-27 09:25:57 PDT
Comment on attachment 336589 [details]
Patch

Clearing flags on attachment: 336589

Committed r229997: <https://trac.webkit.org/changeset/229997>
Comment 6 WebKit Commit Bot 2018-03-27 09:25:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-03-27 09:26:15 PDT
<rdar://problem/38913957>