Bug 184028 - Web Inspector: Command-Shift-left/right arrow keys should not switch tabs when focused on color picker text fields
Summary: Web Inspector: Command-Shift-left/right arrow keys should not switch tabs whe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-26 16:54 PDT by Nikita Vasilyev
Modified: 2018-03-27 12:34 PDT (History)
5 users (show)

See Also:

Attachments
[Animated GIF] Bug (122.56 KB, image/gif)
2018-03-26 16:54 PDT, Nikita Vasilyev 		no flags Details
Patch (1.84 KB, patch)
2018-03-26 16:58 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.24 MB, application/zip)
2018-03-27 06:47 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2018-03-26 16:54:44 PDT 
Created attachment 336554 [details]
[Animated GIF] Bug

Steps:
1. Open http://nv.github.io/webkit-inspector-bugs/styles-redesign/tests/color.html
2. Inspect <h1>
3. Click on a dark colored square before `#333` to open a color picker
4. Focus on R "51" text field
5. Press Command-Shift-Left or Command-Shift-Right

Expected:
Text get selected.

Actual:
Previous or next tab get selected.
Comment 1 Nikita Vasilyev 2018-03-26 16:58:10 PDT 
Created attachment 336555 [details]
Patch
Comment 2 EWS Watchlist 2018-03-27 06:47:32 PDT 
Comment on attachment 336555 [details]
Patch

Attachment 336555 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7112291

New failing tests:
http/tests/preload/download_resources.html
Comment 3 EWS Watchlist 2018-03-27 06:47:42 PDT 
Created attachment 336579 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 Nikita Vasilyev 2018-03-27 10:06:36 PDT 
Comment on attachment 336555 [details]
Patch

Unrelated test regressions.
Comment 5 WebKit Commit Bot 2018-03-27 12:31:04 PDT 
Comment on attachment 336555 [details]
Patch

Clearing flags on attachment: 336555

Committed r230001: <https://trac.webkit.org/changeset/230001>
Comment 6 WebKit Commit Bot 2018-03-27 12:31:05 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-03-27 12:34:08 PDT 
<rdar://problem/38922748>