[Extra zoom mode] Add plumbing for next and previous focusable element rects

[Wenson Hsieh]

Work towards <rdar://problem/38758727>

[Wenson Hsieh]

Created attachment 336528 [details]
Patch

[Tim Horton]

Comment on attachment 336528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336528&action=review

> Source/WebKit/Shared/AssistedNodeInformation.h:97
> +    WebCore::IntRect nextNodeRect;

I guess we’ll get subpixel sparkle if we try to use these without any padding? But that’s OK.

[Wenson Hsieh]

(In reply to Tim Horton from comment #2)
> Comment on attachment 336528 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=336528&action=review
> 
> > Source/WebKit/Shared/AssistedNodeInformation.h:97
> > +    WebCore::IntRect nextNodeRect;
> 
> I guess we’ll get subpixel sparkle if we try to use these without any
> padding? But that’s OK.

I see! Perhaps we should be inflating to device pixel boundaries here? FWIW, the rect of the assisted node currently doesn't adjust for this, but perhaps we could look into it as a followup.

[Tim Horton]

Someday! Not important.

[WebKit Commit Bot]

Comment on attachment 336528 [details]
Patch

Clearing flags on attachment: 336528

Committed r229982: <https://trac.webkit.org/changeset/229982>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.