RESOLVED FIXED184016
[Extra zoom mode] Add plumbing for next and previous focusable element rects 
https://bugs.webkit.org/show_bug.cgi?id=184016
Summary [Extra zoom mode] Add plumbing for next and previous focusable element rects
Wenson Hsieh
Reported 2018-03-26 11:15:36 PDT
Work towards <rdar://problem/38758727>
Attachments
Patch (6.83 KB, patch)
2018-03-26 11:24 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-03-26 11:24:12 PDT
Created attachment 336528 [details] Patch
Tim Horton
Comment 2 2018-03-26 11:32:07 PDT
Comment on attachment 336528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336528&action=review > Source/WebKit/Shared/AssistedNodeInformation.h:97 > + WebCore::IntRect nextNodeRect; I guess we’ll get subpixel sparkle if we try to use these without any padding? But that’s OK.
Wenson Hsieh
Comment 3 2018-03-26 11:38:09 PDT
(In reply to Tim Horton from comment #2) > Comment on attachment 336528 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=336528&action=review > > > Source/WebKit/Shared/AssistedNodeInformation.h:97 > > + WebCore::IntRect nextNodeRect; > > I guess we’ll get subpixel sparkle if we try to use these without any > padding? But that’s OK. I see! Perhaps we should be inflating to device pixel boundaries here? FWIW, the rect of the assisted node currently doesn't adjust for this, but perhaps we could look into it as a followup.
Tim Horton
Comment 4 2018-03-26 11:46:28 PDT
Someday! Not important.
WebKit Commit Bot
Comment 5 2018-03-26 12:09:37 PDT
Comment on attachment 336528 [details] Patch Clearing flags on attachment: 336528 Committed r229982: <https://trac.webkit.org/changeset/229982>
WebKit Commit Bot
Comment 6 2018-03-26 12:09:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.