Bug 183995 - r228149 accidentally removed code that resets m_emptyCursor at the end of a GC
Summary: r228149 accidentally removed code that resets m_emptyCursor at the end of a GC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-25 10:22 PDT by Saam Barati
Modified: 2018-03-25 12:10 PDT (History)
16 users (show)

See Also:


Attachments
patch (1.50 KB, patch)
2018-03-25 10:42 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-03-25 10:22:41 PDT
...
Comment 1 Saam Barati 2018-03-25 10:23:25 PDT
The consequence here is that we end up monotonically growing that cursor, which will eventually lead to us never stealing empty blocks.
Comment 2 Saam Barati 2018-03-25 10:42:22 PDT
Created attachment 336495 [details]
patch
Comment 3 Alexey Proskuryakov 2018-03-25 11:25:30 PDT
Is that a known flaky test?


** The following JSC stress test failures have been introduced:
	stress/ftl-put-by-id-setter-exception-interesting-live-state.js.no-cjit-collect-continuously
Comment 4 WebKit Commit Bot 2018-03-25 11:26:37 PDT
Comment on attachment 336495 [details]
patch

Clearing flags on attachment: 336495

Committed r229962: <https://trac.webkit.org/changeset/229962>
Comment 5 WebKit Commit Bot 2018-03-25 11:26:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-03-25 11:27:19 PDT
<rdar://problem/38843812>
Comment 7 Saam Barati 2018-03-25 11:30:51 PDT
(In reply to Alexey Proskuryakov from comment #3)
> Is that a known flaky test?
> 
> 
> ** The following JSC stress test failures have been introduced:
> 	stress/ftl-put-by-id-setter-exception-interesting-live-state.js.no-cjit-
> collect-continuously

Yes. I've seen it flake before. Do you know how to grab the crashlog from the bots? I'll file a bug or you can and assign it to me.
Comment 8 Alexey Proskuryakov 2018-03-25 12:09:20 PDT
There is no crash log on the bot, looks like the test aborts the process without crashing.

Running stress/ftl-put-by-id-slow-exception-no-catch.js.no-cjit-collect-continuously
stress/ftl-put-by-id-setter-exception-interesting-live-state.js.no-cjit-collect-continuously: Exception: Error42
Running stress/ftl-put-by-id-slow-exception-no-catch.js.dfg-eager
Running stress/ftl-put-by-id-slow-exception-no-catch.js.dfg-eager-no-cjit-validate
stress/ftl-put-by-id-setter-exception-interesting-live-state.js.no-cjit-collect-continuously: ERROR: Unexpected exit code: 3
FAIL: stress/ftl-put-by-id-setter-exception-interesting-live-state.js.no-cjit-collect-continuously
Comment 9 Alexey Proskuryakov 2018-03-25 12:10:30 PDT
Found an existing bug for that, bug 183266.