Bug 183978 - Adopt WK_PLATFORM_NAME in WebKit
Summary: Adopt WK_PLATFORM_NAME in WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-24 01:44 PDT by Tim Horton
Modified: 2018-03-24 21:33 PDT (History)
2 users (show)

See Also:

Attachments
Patch (18.51 KB, patch)
2018-03-24 01:57 PDT, Tim Horton 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-03-24 01:44:14 PDT 
Adopt WK_PLATFORM_NAME in WebKit
Comment 1 Tim Horton 2018-03-24 01:57:23 PDT 
Created attachment 336467 [details]
Patch
Comment 2 mitz 2018-03-24 09:19:59 PDT 
Comment on attachment 336467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336467&action=review

> Source/WebKit/Configurations/WebKit.xcconfig:40
> +WK_WEAK_FRAMEWORK_ON_MAC = $(WK_WEAK_FRAMEWORK_ON_MAC_$(WK_COCOA_TOUCH));

Following the convention in other Apple projects this would be called WK_MACOS_WEAK_FRAMEWORK and go in Base.xcconfig.
Comment 3 Tim Horton 2018-03-24 21:32:57 PDT 
https://trac.webkit.org/changeset/229958/webkit
Comment 4 Radar WebKit Bug Importer 2018-03-24 21:33:51 PDT 
<rdar://problem/38834760>