Bug 183977 - Fix the !ENABLE(MEDIA_STREAM) build
Summary: Fix the !ENABLE(MEDIA_STREAM) build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-24 01:36 PDT by Tim Horton
Modified: 2018-03-24 02:56 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.51 KB, patch)
2018-03-24 01:39 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-03-24 01:36:18 PDT 
Fix the !ENABLE(MEDIA_STREAM) build
Comment 1 Tim Horton 2018-03-24 01:39:05 PDT 
Created attachment 336466 [details]
Patch
Comment 2 Wenson Hsieh 2018-03-24 01:44:06 PDT 
Comment on attachment 336466 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336466&action=review

r=me

> Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:895
>  #endif

Could be worth adding some UNUSED_PARAM()s as needed for debug builds.
Comment 3 Tim Horton 2018-03-24 02:29:39 PDT 
Comment on attachment 336466 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336466&action=review

>> Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:895
>>  #endif
> 
> Could be worth adding some UNUSED_PARAM()s as needed for debug builds.

Don’t think we need them in WK2.
Comment 4 WebKit Commit Bot 2018-03-24 02:55:40 PDT 
Comment on attachment 336466 [details]
Patch

Clearing flags on attachment: 336466

Committed r229950: <https://trac.webkit.org/changeset/229950>
Comment 5 WebKit Commit Bot 2018-03-24 02:55:41 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-03-24 02:56:16 PDT 
<rdar://problem/38823362>