Bug 183973 - Fix the build with no pasteboard
Summary: Fix the build with no pasteboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-23 22:33 PDT by Tim Horton
Modified: 2018-03-24 01:17 PDT (History)
8 users (show)

See Also:

Attachments
Patch (15.56 KB, patch)
2018-03-23 22:33 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (15.51 KB, patch)
2018-03-23 22:50 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-03-23 22:33:25 PDT 
Fix the build with no pasteboard
Comment 1 Tim Horton 2018-03-23 22:33:47 PDT 
Created attachment 336460 [details]
Patch
Comment 2 mitz 2018-03-23 22:39:12 PDT 
Comment on attachment 336460 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336460&action=review

> Source/WebKitLegacy/mac/WebView/WebView.mm:1943
> +#else // ENABLE(DRAG_SUPPORT)

I doubt that the comment is helpful.

> Source/WebKitLegacy/mac/WebView/WebView.mm:2012
> +#endif // !ENABLE(DRAG_SUPPORT)

Ditto.
Comment 3 Tim Horton 2018-03-23 22:50:31 PDT 
Created attachment 336463 [details]
Patch
Comment 4 Tim Horton 2018-03-23 22:58:00 PDT 
https://trac.webkit.org/r229943
Comment 5 Radar WebKit Bug Importer 2018-03-23 22:58:16 PDT 
<rdar://problem/38820296>
Comment 6 Radar WebKit Bug Importer 2018-03-23 22:58:20 PDT 
<rdar://problem/38820298>
Comment 7 Wenson Hsieh 2018-03-24 01:13:31 PDT 
This appears to have broken the watchOS build, wherein ENABLE_DRAG_SUPPORT is 0 and UIDropSession is not defined.

Should we change the #else to #elif __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000?
Comment 8 Tim Horton 2018-03-24 01:14:30 PDT 
(In reply to Wenson Hsieh from comment #7)
> This appears to have broken the watchOS build, wherein ENABLE_DRAG_SUPPORT
> is 0 and UIDropSession is not defined.
> 
> Should we change the #else to #elif __IPHONE_OS_VERSION_MIN_REQUIRED >=
> 110000?

Yes! Will do.
Comment 9 Tim Horton 2018-03-24 01:17:25 PDT 
Did that in https://trac.webkit.org/changeset/229947/webkit