Bug 183966 - Use completion handlers for ResourceHandleClient::canAuthenticateAgainstProtectionSpaceAsync
Summary: Use completion handlers for ResourceHandleClient::canAuthenticateAgainstProte...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-23 17:18 PDT by Alex Christensen
Modified: 2018-03-24 23:20 PDT (History)
5 users (show)

See Also:


Attachments
Patch (16.26 KB, patch)
2018-03-23 17:19 PDT, Alex Christensen
cdumez: review+
cdumez: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-03-23 17:18:54 PDT
Use completion handlers for ResourceHandleClient::canAuthenticateAgainstProtectionSpaceAsync
Comment 1 Alex Christensen 2018-03-23 17:19:47 PDT
Created attachment 336446 [details]
Patch
Comment 2 Chris Dumez 2018-03-23 20:19:47 PDT
Comment on attachment 336446 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336446&action=review

r=me with fix

> Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:366
> +        auto completionHandler = [protectedThis = WTFMove(protectedThis)] (bool result) mutable {

You WTFMove() protectedThis here...

> Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:371
> +        if (!protectedThis->hasHandle())

...but use it here
Comment 3 Alex Christensen 2018-03-24 23:19:19 PDT
Fixed and landed in http://trac.webkit.org/r229959
Comment 4 Radar WebKit Bug Importer 2018-03-24 23:20:18 PDT
<rdar://problem/38835529>