RESOLVED FIXED 183966
Use completion handlers for ResourceHandleClient::canAuthenticateAgainstProtectionSpaceAsync
https://bugs.webkit.org/show_bug.cgi?id=183966
Summary Use completion handlers for ResourceHandleClient::canAuthenticateAgainstProte...
Alex Christensen
Reported 2018-03-23 17:18:54 PDT
Use completion handlers for ResourceHandleClient::canAuthenticateAgainstProtectionSpaceAsync
Attachments
Patch (16.26 KB, patch)
2018-03-23 17:19 PDT, Alex Christensen
cdumez: review+
cdumez: commit-queue-
Alex Christensen
Comment 1 2018-03-23 17:19:47 PDT
Chris Dumez
Comment 2 2018-03-23 20:19:47 PDT
Comment on attachment 336446 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336446&action=review r=me with fix > Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:366 > + auto completionHandler = [protectedThis = WTFMove(protectedThis)] (bool result) mutable { You WTFMove() protectedThis here... > Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:371 > + if (!protectedThis->hasHandle()) ...but use it here
Alex Christensen
Comment 3 2018-03-24 23:19:19 PDT
Fixed and landed in http://trac.webkit.org/r229959
Radar WebKit Bug Importer
Comment 4 2018-03-24 23:20:18 PDT
Note You need to log in before you can comment on or make changes to this bug.