Bug 183960 - Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
Summary: Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-23 16:25 PDT by Tim Horton
Modified: 2018-03-23 19:30 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.06 KB, patch)
2018-03-23 16:27 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (4.86 KB, patch)
2018-03-23 17:04 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-03-23 16:25:31 PDT 
Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
Comment 1 Radar WebKit Bug Importer 2018-03-23 16:26:15 PDT 
<rdar://problem/38812356>
Comment 2 Tim Horton 2018-03-23 16:27:50 PDT 
Created attachment 336439 [details]
Patch
Comment 3 mitz 2018-03-23 16:37:16 PDT 
Comment on attachment 336439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336439&action=review

> Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:68
> +DYLIB_INSTALL_NAME_BASE = $(DYLIB_INSTALL_NAME_BASE_PLATFORM);
> +DYLIB_INSTALL_NAME_BASE_PLATFORM[sdk=iphone*] = $(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
> +DYLIB_INSTALL_NAME_BASE_PLATFORM[sdk=macosx*] = $(DYLIB_INSTALL_NAME_BASE_PLATFORM_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
> +DYLIB_INSTALL_NAME_BASE_PLATFORM_NO = $(NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR);
> +DYLIB_INSTALL_NAME_BASE_PLATFORM_YES = $(DYLIB_INSTALL_NAME_BASE);

This seems unnecessarily complicated and fragile (in case of an SDK that doesn’t match iphone* nor macosx*).
Comment 4 Tim Horton 2018-03-23 17:04:48 PDT 
Created attachment 336445 [details]
Patch
Comment 5 WebKit Commit Bot 2018-03-23 19:30:19 PDT 
Comment on attachment 336445 [details]
Patch

Clearing flags on attachment: 336445

Committed r229942: <https://trac.webkit.org/changeset/229942>
Comment 6 WebKit Commit Bot 2018-03-23 19:30:21 PDT 
All reviewed patches have been landed.  Closing bug.