RESOLVED FIXED 183951
Web Inspector: Styles: don't show checkboxes for invalid properties 
https://bugs.webkit.org/show_bug.cgi?id=183951
Summary Web Inspector: Styles: don't show checkboxes for invalid properties
Nikita Vasilyev
Reported 2018-03-23 14:36:47 PDT
Currently, unchecking an invalid property unexpectedly removes the property. Steps: 1. Open http://nv.github.io/webkit-inspector-bugs/styles-redesign/tests/invalid.html 2. Inspect <body> 3. Click on the checkbox for `color: blah;` or `invalid-name: blah;` Expected: Invalid property disables the same way as a valid property. Actual: Property gets removed. <rdar://problem/36797202> --- Fixing this would require non-trivial CSS parser changes on the backend. The backend has a heuristic to distinguish commented out properties, such as /* font-size: 11px */ from other comments, such as /* make this red */ The CSS parser isn't smart enough to distinguish an invalid CSS property, such as `color: blah`, from a comment that isn't a CSS property at all. As a workaround, I suggest to hide checkboxes for invalid properties. This is exactly what Chrome does.
Attachments
Patch (1.85 KB, patch)
2018-03-23 14:42 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Animated GIF] With patch applied (80.22 KB, image/gif)
2018-03-23 14:46 PDT, Nikita Vasilyev 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-03-23 14:37:09 PDT
<rdar://problem/38807602>
Nikita Vasilyev
Comment 2 2018-03-23 14:42:55 PDT
Created attachment 336424 [details] Patch
Nikita Vasilyev
Comment 3 2018-03-23 14:46:11 PDT
Created attachment 336425 [details] [Animated GIF] With patch applied
Matt Baker
Comment 4 2018-03-23 18:00:33 PDT
Comment on attachment 336424 [details] Patch r=me
WebKit Commit Bot
Comment 5 2018-03-23 18:26:10 PDT
Comment on attachment 336424 [details] Patch Clearing flags on attachment: 336424 Committed r229941: <https://trac.webkit.org/changeset/229941>
WebKit Commit Bot
Comment 6 2018-03-23 18:26:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.