RESOLVED FIXED183947
Add pointer profiling hooks to the CSS JIT.
https://bugs.webkit.org/show_bug.cgi?id=183947
Summary Add pointer profiling hooks to the CSS JIT.
Mark Lam
Reported 2018-03-23 12:37:03 PDT
Patch coming.
Attachments
proposed patch. (13.34 KB, patch)
2018-03-23 12:48 PDT, Mark Lam
jfbastien: review+
ews-watchlist: commit-queue-
proposed patch w/ updated bindings test results. (62.24 KB, patch)
2018-03-23 13:10 PDT, Mark Lam
mark.lam: review+
Radar WebKit Bug Importer
Comment 1 2018-03-23 12:38:07 PDT
Mark Lam
Comment 2 2018-03-23 12:48:41 PDT
Created attachment 336408 [details] proposed patch.
EWS Watchlist
Comment 3 2018-03-23 12:55:26 PDT
Comment on attachment 336408 [details] proposed patch. Attachment 336408 [details] did not pass bindings-ews (mac): Output: http://webkit-queues.webkit.org/results/7077957 New failing tests: (JS) JSTestCallTracer.cpp (JS) JSTestCEReactions.cpp (JS) JSTestCEReactionsStringifier.cpp (JS) JSTestClassWithJSBuiltinConstructor.cpp (JS) JSTestCustomConstructorWithNoInterfaceObject.cpp (JS) JSTestActiveDOMObject.cpp (JS) JSTestEnabledBySetting.cpp (JS) JSTestEventConstructor.cpp (JS) JSTestEventTarget.cpp (JS) JSTestException.cpp (JS) JSTestGenerateIsReachable.cpp (JS) JSTestGlobalObject.cpp (JS) JSTestIndexedSetterNoIdentifier.cpp (JS) JSTestIndexedSetterThrowingException.cpp (JS) JSTestIndexedSetterWithIdentifier.cpp (JS) JSTestIterable.cpp (JS) JSMapLike.cpp (JS) JSTestMediaQueryListListener.cpp (JS) JSTestNamedAndIndexedSetterNoIdentifier.cpp (JS) JSTestNamedAndIndexedSetterThrowingException.cpp (JS) JSTestNamedAndIndexedSetterWithIdentifier.cpp (JS) JSTestNamedConstructor.cpp (JS) JSTestNamedDeleterNoIdentifier.cpp (JS) JSTestNamedDeleterThrowingException.cpp (JS) JSTestNamedDeleterWithIdentifier.cpp (JS) JSTestNamedDeleterWithIndexedGetter.cpp (JS) JSTestNamedGetterCallWith.cpp (JS) JSTestNamedGetterNoIdentifier.cpp (JS) JSTestNamedGetterWithIdentifier.cpp (JS) JSTestNamedSetterNoIdentifier.cpp (JS) JSTestNamedSetterThrowingException.cpp (JS) JSTestNamedSetterWithIdentifier.cpp (JS) JSTestNamedSetterWithIndexedGetter.cpp (JS) JSTestNamedSetterWithIndexedGetterAndSetter.cpp (JS) JSTestNamedSetterWithOverrideBuiltins.cpp (JS) JSTestNamedSetterWithUnforgableProperties.cpp (JS) JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp (JS) JSTestNode.cpp (JS) JSTestObj.cpp (JS) JSTestOverloadedConstructors.cpp (JS) JSTestOverloadedConstructorsWithSequence.cpp (JS) JSTestOverrideBuiltins.cpp (JS) JSTestPluginInterface.cpp (JS) JSTestPromiseRejectionEvent.cpp (JS) JSReadOnlyMapLike.cpp (JS) JSInterfaceName.cpp (JS) JSTestSerialization.cpp (JS) JSTestSerializedScriptValueInterface.cpp (JS) JSTestStringifier.cpp (JS) JSTestStringifierAnonymousOperation.cpp (JS) JSTestStringifierNamedOperation.cpp (JS) JSTestStringifierOperationImplementedAs.cpp (JS) JSTestStringifierOperationNamedToString.cpp (JS) JSTestStringifierReadOnlyAttribute.cpp (JS) JSTestStringifierReadWriteAttribute.cpp (JS) JSTestTypedefs.cpp
Mark Lam
Comment 4 2018-03-23 13:10:26 PDT
Created attachment 336415 [details] proposed patch w/ updated bindings test results.
JF Bastien
Comment 5 2018-03-23 13:11:27 PDT
Comment on attachment 336408 [details] proposed patch. r=me modulo tests fail
Mark Lam
Comment 6 2018-03-23 13:14:32 PDT
Comment on attachment 336415 [details] proposed patch w/ updated bindings test results. JF already r+ed. The failures were binding tests that just need to be rebased. Will wait for EWS to confirm.
Mark Lam
Comment 7 2018-03-23 16:29:03 PDT
Thanks for the review. Landed in r229931: <http://trac.webkit.org/r229931>.
Note You need to log in before you can comment on or make changes to this bug.