Bug 183946 - HTMLElement factory doesn't need to call MediaPlayer::isAvailable
Summary: HTMLElement factory doesn't need to call MediaPlayer::isAvailable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-23 12:15 PDT by Eric Carlson
Modified: 2018-03-23 13:11 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.57 KB, patch)
2018-03-23 12:21 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2018-03-23 12:15:25 PDT 
The HTMLVideoElement, HTMLAudioElement, and HTMLTrackElement constructors check both document.settings().mediaEnabled() and MediaPlayer::isAvailable to see if media is disabled. Ports should disable the setting if they don't want media elements, so the later is redundant.
Comment 1 Radar WebKit Bug Importer 2018-03-23 12:15:53 PDT 
<rdar://problem/38802687>
Comment 2 Eric Carlson 2018-03-23 12:21:03 PDT 
Created attachment 336403 [details]
Patch
Comment 3 WebKit Commit Bot 2018-03-23 13:11:57 PDT 
Comment on attachment 336403 [details]
Patch

Clearing flags on attachment: 336403

Committed r229915: <https://trac.webkit.org/changeset/229915>
Comment 4 WebKit Commit Bot 2018-03-23 13:11:58 PDT 
All reviewed patches have been landed.  Closing bug.