Bug 183945 – CacheStorage::Caches should clear m_caches when clearing its representation even though it is not yet initialized

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

Otherwise we end up in
Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x00000000bbadbeef
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Segmentation fault: 11
Termination Reason:    Namespace SIGNAL, Code 0xb
Terminating Process:   exc handler [0]

VM Regions Near 0xbbadbeef:
--> 
    __TEXT                 0000000108690000-0000000108692000 [    8K] r-x/rwx SM=COW  /Users/USER/*/WebKit.framework/Versions/A/XPCServices/com.apple.WebKit.Networking.xpc/Contents/MacOS/com.apple.WebKit.Networking.Development

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.JavaScriptCore      	0x0000000122b14774 WTFCrash + 36 (Assertions.cpp:271)
1   com.apple.WebKit              	0x00000001087a7bef WebKit::CacheStorage::Caches::clearMemoryRepresentation() + 95 (CacheStorageEngineCaches.cpp:551)
2   com.apple.WebKit              	0x00000001087b380b WebKit::CacheStorage::Caches::clear(WTF::CompletionHandler<void ()>&&)::$_6::operator()() + 91 (CacheStorageEngineCaches.cpp:237)
3   com.apple.WebKit              	0x00000001087b3709 WTF::Function<void ()>::CallableWrapper<WebKit::CacheStorage::Caches::clear(WTF::CompletionHandler<void ()>&&)::$_6>::call() + 25 (Function.h:101)
4   com.apple.WebKit              	0x000000010870694b WTF::Function<void ()>::operator()() const + 139 (Function.h:56)
5   com.apple.WebKit              	0x00000001089bbeb0 WebKit::NetworkCache::Storage::clear(WTF::String const&, WTF::WallTime, WTF::Function<void ()>&&)::$_11::operator()()::'lambda'()::operator()() const + 64 (NetworkCacheStorage.cpp:986)
6   com.apple.WebKit              	0x00000001089bbdc9 WTF::Function<void ()>::CallableWrapper<WebKit::NetworkCache::Storage::clear(WTF::String const&, WTF::WallTime, WTF::Function<void ()>&&)::$_11::operator()()::'lambda'()>::call() + 25 (Function.h:101)
7   com.apple.JavaScriptCore      	0x0000000122b3066b WTF::Function<void ()>::operator()() const + 139 (Function.h:56)
8   com.apple.JavaScriptCore      	0x0000000122b753b3 WTF::RunLoop::performWork() + 211 (RunLoop.cpp:107)
9   com.apple.JavaScriptCore      	0x0000000122b75c54 WTF::RunLoop::performWork(void*) + 36 (RunLoopCF.cpp:38)
10  com.apple.CoreFoundation      	0x00007fff509a6d81 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
11  com.apple.CoreFoundation      	0x00007fff50a5e65c __CFRunLoopDoSource0 + 108
12  com.apple.CoreFoundation      	0x00007fff50989d30 __CFRunLoopDoSources0 + 208
13  com.apple.CoreFoundation      	0x00007fff509891ad __CFRunLoopRun + 1293
14  com.apple.CoreFoundation      	0x00007fff50988a07 CFRunLoopRunSpecific + 487
15  com.apple.Foundation          	0x00007fff52a92f26 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277
16  com.apple.Foundation          	0x00007fff52a92dfe -[NSRunLoop(NSRunLoop) run] + 76
17  libxpc.dylib                  	0x00007fff791f5f2b _xpc_objc_main + 536
18  libxpc.dylib                  	0x00007fff791f4baa xpc_main + 417
19  com.apple.WebKit.Networking   	0x000000010869113b main + 1195 (XPCServiceMain.mm:148)
20  libdyld.dylib                 	0x00007fff78e9b015 start + 1

[youenn fablet]

Created attachment 336398 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 336398 [details]
Patch

Clearing flags on attachment: 336398

Committed r229914: <https://trac.webkit.org/changeset/229914>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/38804080>