Bug 183944 - [Extra zoom mode] Adopt list view controller UI for select menus
Summary: [Extra zoom mode] Adopt list view controller UI for select menus
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-23 10:51 PDT by Wenson Hsieh
Modified: 2018-03-23 15:35 PDT (History)
7 users (show)

See Also:

Attachments
Patch (25.10 KB, patch)
2018-03-23 10:59 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch for landing (25.04 KB, patch)
2018-03-23 12:49 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Move new files to ios/forms/ (16.79 KB, patch)
2018-03-23 14:57 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-03-23 10:51:23 PDT 
<rdar://problem/38799062>
Comment 1 Wenson Hsieh 2018-03-23 10:59:18 PDT 
Created attachment 336390 [details]
Patch
Comment 2 Andy Estes 2018-03-23 11:23:21 PDT 
Comment on attachment 336390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336390&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4221
> +    _selectMenuListViewController = adoptNS([[WKSelectMenuListViewController alloc] initWithDelegate:self]);
> +    [_selectMenuListViewController setDelegate:self];

Do you really need to call -initWithDelegate: and -setDelegate:?
Comment 3 Wenson Hsieh 2018-03-23 11:24:09 PDT 
Comment on attachment 336390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336390&action=review

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4221
>> +    [_selectMenuListViewController setDelegate:self];
> 
> Do you really need to call -initWithDelegate: and -setDelegate:?

Oops, we definitely don't. Good catch!
Comment 4 Wenson Hsieh 2018-03-23 12:49:30 PDT 
Created attachment 336410 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-03-23 13:47:24 PDT 
Comment on attachment 336410 [details]
Patch for landing

Clearing flags on attachment: 336410

Committed r229916: <https://trac.webkit.org/changeset/229916>
Comment 6 Wenson Hsieh 2018-03-23 14:57:11 PDT 
Created attachment 336428 [details]
Move new files to ios/forms/
Comment 7 WebKit Commit Bot 2018-03-23 15:35:44 PDT 
Comment on attachment 336428 [details]
Move new files to ios/forms/

Clearing flags on attachment: 336428

Committed r229928: <https://trac.webkit.org/changeset/229928>
Comment 8 WebKit Commit Bot 2018-03-23 15:35:46 PDT 
All reviewed patches have been landed.  Closing bug.