RESOLVED FIXED 183943
Add more support for pointer profiling. 
https://bugs.webkit.org/show_bug.cgi?id=183943
Summary Add more support for pointer profiling.
Mark Lam
Reported 2018-03-23 10:50:18 PDT
Patch coming.
Attachments
proposed patch. (2.77 KB, patch)
2018-03-23 11:14 PDT, Mark Lam 		jfbastien: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-03-23 10:51:03 PDT
<rdar://problem/38799068>
Mark Lam
Comment 2 2018-03-23 11:14:48 PDT
Created attachment 336392 [details] proposed patch.
JF Bastien
Comment 3 2018-03-23 11:25:20 PDT
Comment on attachment 336392 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=336392&action=review r=me > Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:898 > + assertIsTaggedWith(destination.executableAddress(), NearCallPtrTag); This won't be called when doing linking right? I'd expect the pointer to be zero at that point.
Mark Lam
Comment 4 2018-03-23 11:43:12 PDT
Comment on attachment 336392 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=336392&action=review >> Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:898 >> + assertIsTaggedWith(destination.executableAddress(), NearCallPtrTag); > > This won't be called when doing linking right? I'd expect the pointer to be zero at that point. This is a repatch function. Hence, the destination that we're patching to should never be null.
Mark Lam
Comment 5 2018-03-23 11:45:04 PDT
Thanks for the review. Landed in r229911: <http://trac.webkit.org/r229911>.
Note You need to log in before you can comment on or make changes to this bug.