Bug 183943 - Add more support for pointer profiling.
Summary: Add more support for pointer profiling.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-23 10:50 PDT by Mark Lam
Modified: 2018-03-23 11:45 PDT (History)
7 users (show)

See Also:


Attachments
proposed patch. (2.77 KB, patch)
2018-03-23 11:14 PDT, Mark Lam
jfbastien: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-03-23 10:50:18 PDT
Patch coming.
Comment 1 Radar WebKit Bug Importer 2018-03-23 10:51:03 PDT
<rdar://problem/38799068>
Comment 2 Mark Lam 2018-03-23 11:14:48 PDT
Created attachment 336392 [details]
proposed patch.
Comment 3 JF Bastien 2018-03-23 11:25:20 PDT
Comment on attachment 336392 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=336392&action=review

r=me

> Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:898
> +        assertIsTaggedWith(destination.executableAddress(), NearCallPtrTag);

This won't be called when doing linking right? I'd expect the pointer to be zero at that point.
Comment 4 Mark Lam 2018-03-23 11:43:12 PDT
Comment on attachment 336392 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=336392&action=review

>> Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:898
>> +        assertIsTaggedWith(destination.executableAddress(), NearCallPtrTag);
> 
> This won't be called when doing linking right? I'd expect the pointer to be zero at that point.

This is a repatch function.  Hence, the destination that we're patching to should never be null.
Comment 5 Mark Lam 2018-03-23 11:45:04 PDT
Thanks for the review.  Landed in r229911: <http://trac.webkit.org/r229911>.