Bug 183940 - Web Inspector: add WebKitAdditions hooks for WebInspectorUI
Summary: Web Inspector: add WebKitAdditions hooks for WebInspectorUI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-23 09:43 PDT by Brian Burg
Modified: 2018-03-23 16:35 PDT (History)
8 users (show)

See Also:


Attachments
Patch (16.57 KB, patch)
2018-03-23 11:13 PDT, Brian Burg
timothy: review+
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.48 MB, application/zip)
2018-03-23 12:19 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2018-03-23 09:43:10 PDT
.
Comment 1 Radar WebKit Bug Importer 2018-03-23 09:43:45 PDT
<rdar://problem/38796310>
Comment 2 Brian Burg 2018-03-23 11:13:25 PDT
Created attachment 336391 [details]
Patch
Comment 3 Timothy Hatcher 2018-03-23 11:18:41 PDT
Comment on attachment 336391 [details]
Patch

Nice clean up!
Comment 4 Build Bot 2018-03-23 12:19:16 PDT
Comment on attachment 336391 [details]
Patch

Attachment 336391 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7077021

New failing tests:
media/modern-media-controls/tracks-panel/tracks-panel-position-and-size.html
Comment 5 Build Bot 2018-03-23 12:19:17 PDT
Created attachment 336402 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 6 Brian Burg 2018-03-23 16:35:07 PDT
Committed r229932: <https://trac.webkit.org/changeset/229932>