Bug 183939 - dump-class-layout is just wrong
Summary: dump-class-layout is just wrong
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: JF Bastien
URL:
Keywords: InRadar
Depends on: 183311
Blocks:
  Show dependency treegraph
 
Reported: 2018-03-23 09:24 PDT by JF Bastien
Modified: 2018-03-26 13:19 PDT (History)
8 users (show)

See Also:


Attachments
patch (2.78 KB, patch)
2018-03-23 09:26 PDT, JF Bastien
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description JF Bastien 2018-03-23 09:24:58 PDT
Looks like r229291 contained a half-renamed variable in it, so it just doesn't work.
Comment 1 JF Bastien 2018-03-23 09:26:34 PDT
Created attachment 336379 [details]
patch
Comment 2 Yusuke Suzuki 2018-03-23 09:41:24 PDT
Comment on attachment 336379 [details]
patch

r=me
Comment 3 WebKit Commit Bot 2018-03-23 10:07:51 PDT
Comment on attachment 336379 [details]
patch

Clearing flags on attachment: 336379

Committed r229900: <https://trac.webkit.org/changeset/229900>
Comment 4 WebKit Commit Bot 2018-03-23 10:07:53 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-03-23 10:08:16 PDT
<rdar://problem/38797356>
Comment 6 Simon Fraser (smfr) 2018-03-23 12:09:16 PDT
Dan was looking at adding tests for this script.
Comment 7 Joseph Pecoraro 2018-03-26 13:19:41 PDT
The title of this bug is misleading. It seems to indicate that the script is wrong, but in reality it just saying that there was a runtime error.