Bug 183935 – [Web Animations] Correctly handle timing functions specified by CSS Animations and CSS Transitions

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

[Web Animations] Correctly handle timing functions specified by CSS Animations and CSS Transitions

[Antoine Quint]

Created attachment 336373 [details]
Patch

[Antoine Quint]

Created attachment 336374 [details]
Patch

[EWS Watchlist]

Comment on attachment 336374 [details]
Patch

Attachment 336374 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7080168

New failing tests:
imported/mozilla/css-animations/test_animation-computed-timing.html
imported/mozilla/css-transitions/test_keyframeeffect-getkeyframes.html

[EWS Watchlist]

Created attachment 336438 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Dean Jackson]

Comment on attachment 336374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336374&action=review

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:529
> +            // For CSS transitions, there are only two keyframes and the second keyframe should always report "linear". In practice, this value
> +            // has no bearing since, as the last keyframe, its value will never be used.
> +            computedKeyframe.easing = is<CSSTransition>(animation()) && i == 1 ? "linear" : timingFunctionForKeyframeAtIndex(0)->cssText();

I know this doesn't matter in this case, but I believe "ease" should be the default.

[Antoine Quint]

Committed r229981: <https://trac.webkit.org/changeset/229981>

[Radar WebKit Bug Importer]

<rdar://problem/38876222>