Bug 183935 - [Web Animations] Correctly handle timing functions specified by CSS Animations and CSS Transitions
Summary: [Web Animations] Correctly handle timing functions specified by CSS Animation...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-23 08:17 PDT by Antoine Quint
Modified: 2018-03-26 12:10 PDT (History)
3 users (show)

See Also:

Attachments
Patch (25.03 KB, patch)
2018-03-23 08:26 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (24.50 KB, patch)
2018-03-23 08:32 PDT, Antoine Quint 		dino: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews205 for win-future (12.20 MB, application/zip)
2018-03-23 16:21 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-03-23 08:17:16 PDT 
[Web Animations] Correctly handle timing functions specified by CSS Animations and CSS Transitions
Comment 1 Antoine Quint 2018-03-23 08:26:07 PDT 
Created attachment 336373 [details]
Patch
Comment 2 Antoine Quint 2018-03-23 08:32:47 PDT 
Created attachment 336374 [details]
Patch
Comment 3 EWS Watchlist 2018-03-23 16:21:04 PDT 
Comment on attachment 336374 [details]
Patch

Attachment 336374 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7080168

New failing tests:
imported/mozilla/css-animations/test_animation-computed-timing.html
imported/mozilla/css-transitions/test_keyframeeffect-getkeyframes.html
Comment 4 EWS Watchlist 2018-03-23 16:21:15 PDT 
Created attachment 336438 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Dean Jackson 2018-03-26 10:58:31 PDT 
Comment on attachment 336374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336374&action=review

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:529
> +            // For CSS transitions, there are only two keyframes and the second keyframe should always report "linear". In practice, this value
> +            // has no bearing since, as the last keyframe, its value will never be used.
> +            computedKeyframe.easing = is<CSSTransition>(animation()) && i == 1 ? "linear" : timingFunctionForKeyframeAtIndex(0)->cssText();

I know this doesn't matter in this case, but I believe "ease" should be the default.
Comment 6 Antoine Quint 2018-03-26 12:08:08 PDT 
Committed r229981: <https://trac.webkit.org/changeset/229981>
Comment 7 Radar WebKit Bug Importer 2018-03-26 12:10:18 PDT 
<rdar://problem/38876222>