Bug 183924 - Add support for VCP encoder on MacOS and iOS
Summary: Add support for VCP encoder on MacOS and iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-22 16:41 PDT by youenn fablet
Modified: 2018-03-23 14:20 PDT (History)
7 users (show)

See Also:


Attachments
Patch (28.38 KB, patch)
2018-03-22 16:44 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews112 for mac-sierra (2.94 MB, application/zip)
2018-03-22 19:59 PDT, EWS Watchlist
no flags Details
Patch (28.38 KB, patch)
2018-03-23 12:46 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (28.63 KB, patch)
2018-03-23 13:25 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-03-22 16:41:21 PDT
Add support for VCP encoder on MacOS and iOS
Comment 1 youenn fablet 2018-03-22 16:44:41 PDT
Created attachment 336330 [details]
Patch
Comment 2 EWS Watchlist 2018-03-22 19:59:37 PDT
Comment on attachment 336330 [details]
Patch

Attachment 336330 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7069754

New failing tests:
media/modern-media-controls/tracks-panel/tracks-panel-position-and-size.html
Comment 3 EWS Watchlist 2018-03-22 19:59:38 PDT
Created attachment 336347 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 youenn fablet 2018-03-22 20:42:12 PDT
media/modern-media-controls/tracks-panel/tracks-panel-position-and-size.html failure is unrelated and seems to be an issue for other patches as well
Comment 5 Eric Carlson 2018-03-23 11:44:15 PDT
Comment on attachment 336330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336330&action=review

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.cpp:74
> +SOFT_LINK_FUNCTION_FOR_SOURCE(webrtc, VideoProcessing, VCPCompressionSessionEncodeFrame, OSStatus, (VCPCompressionSessionRef session, CVImageBufferRef buffer, CMTime timestamp, CMTime time, CFDictionaryRef dictionary, void * data, VTEncodeInfoFlags * flags), (session, buffer, timestamp, time, dictionary, data, flags))
> +SOFT_LINK_FUNCTION_FOR_SOURCE(webrtc, VideoProcessing, VCPCompressionSessionCreate, OSStatus, (CFAllocatorRef allocator1, int32_t value1 , int32_t value2, CMVideoCodecType type, CFDictionaryRef dictionary1, CFDictionaryRef dictionary2, CFAllocatorRef allocator3, VTCompressionOutputCallback callback, void * data, VCPCompressionSessionRef *session), (allocator1, value1, value2, type, dictionary1, dictionary2, allocator3, callback, data, session))

Nit: shouldn't have spaces on both sides of the "*"s
Comment 6 youenn fablet 2018-03-23 12:46:08 PDT
Created attachment 336406 [details]
Patch
Comment 7 youenn fablet 2018-03-23 12:46:26 PDT
(In reply to youenn fablet from comment #6)
> Created attachment 336406 [details]
> Patch

Thanks for the review, fixed!
Comment 8 WebKit Commit Bot 2018-03-23 12:53:38 PDT
Comment on attachment 336406 [details]
Patch

Rejecting attachment 336406 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 336406, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/ThirdParty/libwebrtc/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/7077944
Comment 9 youenn fablet 2018-03-23 13:25:01 PDT
Created attachment 336416 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2018-03-23 14:19:01 PDT
Comment on attachment 336416 [details]
Patch for landing

Clearing flags on attachment: 336416

Committed r229920: <https://trac.webkit.org/changeset/229920>
Comment 11 WebKit Commit Bot 2018-03-23 14:19:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2018-03-23 14:20:35 PDT
<rdar://problem/38807015>