Bug 183924 – Add support for VCP encoder on MacOS and iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Add support for VCP encoder on MacOS and iOS

[youenn fablet]

Created attachment 336330 [details]
Patch

[EWS Watchlist]

Comment on attachment 336330 [details]
Patch

Attachment 336330 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7069754

New failing tests:
media/modern-media-controls/tracks-panel/tracks-panel-position-and-size.html

[EWS Watchlist]

Created attachment 336347 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6

[youenn fablet]

media/modern-media-controls/tracks-panel/tracks-panel-position-and-size.html failure is unrelated and seems to be an issue for other patches as well

[Eric Carlson]

Comment on attachment 336330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336330&action=review

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.cpp:74
> +SOFT_LINK_FUNCTION_FOR_SOURCE(webrtc, VideoProcessing, VCPCompressionSessionEncodeFrame, OSStatus, (VCPCompressionSessionRef session, CVImageBufferRef buffer, CMTime timestamp, CMTime time, CFDictionaryRef dictionary, void * data, VTEncodeInfoFlags * flags), (session, buffer, timestamp, time, dictionary, data, flags))
> +SOFT_LINK_FUNCTION_FOR_SOURCE(webrtc, VideoProcessing, VCPCompressionSessionCreate, OSStatus, (CFAllocatorRef allocator1, int32_t value1 , int32_t value2, CMVideoCodecType type, CFDictionaryRef dictionary1, CFDictionaryRef dictionary2, CFAllocatorRef allocator3, VTCompressionOutputCallback callback, void * data, VCPCompressionSessionRef *session), (allocator1, value1, value2, type, dictionary1, dictionary2, allocator3, callback, data, session))

Nit: shouldn't have spaces on both sides of the "*"s

[youenn fablet]

Created attachment 336406 [details]
Patch

[youenn fablet]

(In reply to youenn fablet from comment #6)
> Created attachment 336406 [details]
> Patch

Thanks for the review, fixed!

[WebKit Commit Bot]

Comment on attachment 336406 [details]
Patch

Rejecting attachment 336406 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 336406, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/ThirdParty/libwebrtc/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/7077944

[youenn fablet]

Created attachment 336416 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 336416 [details]
Patch for landing

Clearing flags on attachment: 336416

Committed r229920: <https://trac.webkit.org/changeset/229920>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/38807015>