WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
183921
Use the same SWServer for all ephemeral sessions
https://bugs.webkit.org/show_bug.cgi?id=183921
Summary
Use the same SWServer for all ephemeral sessions
Chris Dumez
Reported
2018-03-22 15:52:19 PDT
Use the same SWServer for all ephemeral sessions. SWServers never go away and we create one per sessionID. When browsing doing private browsing in Safari (and other fetching favorite icons), the sessionID is ephemeral and keeps changing. This means that we kept constructing new SWServers that would never go away. Each SWServer has a thread so we would eventually hit the thread limit for the storage process.
Attachments
Patch
(1.95 KB, patch)
2018-03-22 15:53 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2018-03-22 15:52:37 PDT
<
rdar://problem/36873075
>
Chris Dumez
Comment 2
2018-03-22 15:53:58 PDT
Created
attachment 336319
[details]
Patch
Brady Eidson
Comment 3
2018-03-22 16:31:30 PDT
Comment on
attachment 336319
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=336319&action=review
Not going to r-, but I do have one nit
> Source/WebKit/StorageProcess/StorageProcess.cpp:438 > + // Use the same SWServer for all ephemeral sessions. > + if (sessionID.isEphemeral()) > + sessionID = PAL::SessionID::legacyPrivateSessionID();
We eventually want legacyPrivateSessionID() to go away. So it would be nicer if we had some sort of shared "global ephemeral SWServer session ID" But we can also do that later when we get rid of the legacy one.
WebKit Commit Bot
Comment 4
2018-03-22 17:01:00 PDT
Comment on
attachment 336319
[details]
Patch Clearing flags on attachment: 336319 Committed
r229872
: <
https://trac.webkit.org/changeset/229872
>
WebKit Commit Bot
Comment 5
2018-03-22 17:01:01 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug