Bug 183920 - Go to back/forward list items after a process-swapped navigation
Summary: Go to back/forward list items after a process-swapped navigation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-22 15:45 PDT by Brady Eidson
Modified: 2018-03-26 10:42 PDT (History)
11 users (show)

See Also:


Attachments
Patch (67.59 KB, patch)
2018-03-23 10:45 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (68.31 KB, patch)
2018-03-23 11:26 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (69.15 KB, patch)
2018-03-23 12:26 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (71.01 KB, patch)
2018-03-23 14:20 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2018-03-22 15:45:37 PDT
Go to back/forward list items after a process-swapped navigation
Comment 1 Brady Eidson 2018-03-22 15:45:49 PDT
<rdar://problem/38690544>
Comment 2 Brady Eidson 2018-03-23 10:45:44 PDT
Created attachment 336388 [details]
Patch
Comment 3 EWS Watchlist 2018-03-23 10:47:12 PDT
Attachment 336388 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:121:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:130:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:132:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:135:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:141:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 5 in 38 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Brady Eidson 2018-03-23 11:26:46 PDT
Created attachment 336394 [details]
Patch
Comment 5 EWS Watchlist 2018-03-23 11:29:32 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 6 EWS Watchlist 2018-03-23 11:30:00 PDT
Attachment 336394 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:121:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:130:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:132:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:135:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:141:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 5 in 39 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Brady Eidson 2018-03-23 12:26:39 PDT
Created attachment 336405 [details]
Patch
Comment 8 EWS Watchlist 2018-03-23 12:29:10 PDT
Attachment 336405 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:121:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:130:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:132:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:135:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:141:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 5 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Brady Eidson 2018-03-23 14:20:48 PDT
Created attachment 336421 [details]
Patch
Comment 10 EWS Watchlist 2018-03-23 14:22:45 PDT
Attachment 336421 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:121:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:130:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:132:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:135:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:141:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 5 in 42 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 WebKit Commit Bot 2018-03-23 15:15:28 PDT
Comment on attachment 336421 [details]
Patch

Clearing flags on attachment: 336421

Committed r229926: <https://trac.webkit.org/changeset/229926>
Comment 12 WebKit Commit Bot 2018-03-23 15:15:29 PDT
All reviewed patches have been landed.  Closing bug.
Comment 13 Ryan Haddad 2018-03-23 16:39:07 PDT
This change broke the Windows build:
https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/8448

C:\cygwin\home\buildbot\slave\win-release\build\Source\WebKitLegacy\win\WebView.cpp(3436): error C2027: use of undefined type 'WebCore::NavigationPolicyCheck' [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj]
  C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\DerivedSources\ForwardingHeaders\WebCore/HistoryController.h(43): note: see declaration of 'WebCore::NavigationPolicyCheck'
C:\cygwin\home\buildbot\slave\win-release\build\Source\WebKitLegacy\win\WebView.cpp(3436): error C2065: 'Require': undeclared identifier [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj]
C:\cygwin\home\buildbot\slave\win-release\build\Source\WebKitLegacy\win\WebView.cpp(5963): error C2027: use of undefined type 'WebCore::NavigationPolicyCheck' [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj]
  C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\DerivedSources\ForwardingHeaders\WebCore/HistoryController.h(43): note: see declaration of 'WebCore::NavigationPolicyCheck'
C:\cygwin\home\buildbot\slave\win-release\build\Source\WebKitLegacy\win\WebView.cpp(5963): error C2065: 'Require': undeclared identifier [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj]
Comment 14 Chris Dumez 2018-03-23 16:42:18 PDT
(In reply to Ryan Haddad from comment #13)
> This change broke the Windows build:
> https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/
> 8448
> 
> C:\cygwin\home\buildbot\slave\win-
> release\build\Source\WebKitLegacy\win\WebView.cpp(3436): error C2027: use of
> undefined type 'WebCore::NavigationPolicyCheck'
> [C:\cygwin\home\buildbot\slave\win-
> release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj]
>  
> C:\cygwin\home\buildbot\slave\win-
> release\build\WebKitBuild\Release\DerivedSources\ForwardingHeaders\WebCore/
> HistoryController.h(43): note: see declaration of
> 'WebCore::NavigationPolicyCheck'
> C:\cygwin\home\buildbot\slave\win-
> release\build\Source\WebKitLegacy\win\WebView.cpp(3436): error C2065:
> 'Require': undeclared identifier
> [C:\cygwin\home\buildbot\slave\win-
> release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj]
> C:\cygwin\home\buildbot\slave\win-
> release\build\Source\WebKitLegacy\win\WebView.cpp(5963): error C2027: use of
> undefined type 'WebCore::NavigationPolicyCheck'
> [C:\cygwin\home\buildbot\slave\win-
> release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj]
>  
> C:\cygwin\home\buildbot\slave\win-
> release\build\WebKitBuild\Release\DerivedSources\ForwardingHeaders\WebCore/
> HistoryController.h(43): note: see declaration of
> 'WebCore::NavigationPolicyCheck'
> C:\cygwin\home\buildbot\slave\win-
> release\build\Source\WebKitLegacy\win\WebView.cpp(5963): error C2065:
> 'Require': undeclared identifier
> [C:\cygwin\home\buildbot\slave\win-
> release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj]

Follow-up Windows build fix:
<https://trac.webkit.org/changeset/229934>
Comment 15 Brady Eidson 2018-03-26 10:42:08 PDT
(In reply to Chris Dumez from comment #14)
> (In reply to Ryan Haddad from comment #13)
> > This change broke the Windows build:
> > https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/
> > 8448
> > 
> > C:\cygwin\home\buildbot\slave\win-
> > release\build\Source\WebKitLegacy\win\WebView.cpp(3436): error C2027: use of
> > undefined type 'WebCore::NavigationPolicyCheck'
> > [C:\cygwin\home\buildbot\slave\win-
> > release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj]
> >  
> > C:\cygwin\home\buildbot\slave\win-
> > release\build\WebKitBuild\Release\DerivedSources\ForwardingHeaders\WebCore/
> > HistoryController.h(43): note: see declaration of
> > 'WebCore::NavigationPolicyCheck'
> > C:\cygwin\home\buildbot\slave\win-
> > release\build\Source\WebKitLegacy\win\WebView.cpp(3436): error C2065:
> > 'Require': undeclared identifier
> > [C:\cygwin\home\buildbot\slave\win-
> > release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj]
> > C:\cygwin\home\buildbot\slave\win-
> > release\build\Source\WebKitLegacy\win\WebView.cpp(5963): error C2027: use of
> > undefined type 'WebCore::NavigationPolicyCheck'
> > [C:\cygwin\home\buildbot\slave\win-
> > release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj]
> >  
> > C:\cygwin\home\buildbot\slave\win-
> > release\build\WebKitBuild\Release\DerivedSources\ForwardingHeaders\WebCore/
> > HistoryController.h(43): note: see declaration of
> > 'WebCore::NavigationPolicyCheck'
> > C:\cygwin\home\buildbot\slave\win-
> > release\build\Source\WebKitLegacy\win\WebView.cpp(5963): error C2065:
> > 'Require': undeclared identifier
> > [C:\cygwin\home\buildbot\slave\win-
> > release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj]
> 
> Follow-up Windows build fix:
> <https://trac.webkit.org/changeset/229934>

Thank you.