Bug 183899 - [JSC] Drop op_put_by_index
Summary: [JSC] Drop op_put_by_index
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-22 07:31 PDT by Yusuke Suzuki
Modified: 2018-03-22 08:42 PDT (History)
6 users (show)

See Also:


Attachments
Patch (12.87 KB, patch)
2018-03-22 07:35 PDT, Yusuke Suzuki
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-03-22 07:31:17 PDT
[JSC] Drop op_put_by_index
Comment 1 Yusuke Suzuki 2018-03-22 07:35:01 PDT
Created attachment 336281 [details]
Patch
Comment 2 Mark Lam 2018-03-22 07:45:59 PDT
Comment on attachment 336281 [details]
Patch

r=me but please run perf numbers to confirm no perf impact before landing.
Comment 3 Yusuke Suzuki 2018-03-22 08:23:49 PDT
(In reply to Mark Lam from comment #2)
> Comment on attachment 336281 [details]
> Patch
> 
> r=me but please run perf numbers to confirm no perf impact before landing.

Perf numbers are neutral.

                                                 baseline                  patched
Octane:
   encrypt                                   0.24878+-0.00577    ?     0.25183+-0.00384       ? might be 1.0123x slower
   decrypt                                   3.72432+-0.02746    ?     3.77940+-0.09633       ? might be 1.0148x slower
   deltablue                        x2       0.23028+-0.02989          0.22606+-0.01642         might be 1.0187x faster
   earley                                    0.49032+-0.00873    ?     0.49064+-0.00778       ?
   boyer                                     9.07910+-0.14014          8.80682+-0.14192         might be 1.0309x faster
   navier-stokes                    x2       5.28574+-0.00560    ?     5.28833+-0.01901       ?
   raytrace                         x2       1.18310+-0.10043          1.15976+-0.03741         might be 1.0201x faster
   richards                         x2       0.11285+-0.00763    ?     0.11422+-0.00910       ? might be 1.0122x slower
   splay                            x2       0.46088+-0.00847          0.45366+-0.00296         might be 1.0159x faster
   regexp                           x2      26.62591+-0.69491         26.04150+-0.25518         might be 1.0224x faster
   pdfjs                            x2      55.36628+-0.75967         54.48570+-0.51859         might be 1.0162x faster
   mandreel                         x2      73.05758+-1.96074         71.57133+-1.68308         might be 1.0208x faster
   gbemu                            x2      61.46739+-10.66688        58.54453+-4.89309         might be 1.0499x faster
   closure                                   0.75497+-0.01261    ?     0.75751+-0.01854       ?
   jquery                                   10.30042+-0.47108         10.04608+-0.26924         might be 1.0253x faster
   box2d                            x2      13.47528+-0.45045    ?    13.61869+-0.48499       ? might be 1.0106x slower
   zlib                             x2     436.32650+-7.02990        433.93129+-12.37712
   typescript                       x2     869.14741+-6.23240    ?   872.75107+-14.88755      ?
   splay-latency                             2.10483+-0.03816    ?     2.10847+-0.04328       ?

   <geometric>                               7.21142+-0.09608          7.15287+-0.05774         might be 1.0082x faster

                                                 baseline                  patched
Kraken:
   ai-astar                                  142.287+-4.044            140.243+-4.630           might be 1.0146x faster
   audio-beat-detection                       60.855+-2.116             60.599+-2.025
   audio-dft                                  90.556+-1.450      ?      91.799+-2.580         ? might be 1.0137x slower
   audio-fft                                  46.795+-1.420             46.200+-1.372           might be 1.0129x faster
   audio-oscillator                           80.361+-3.406             78.968+-2.562           might be 1.0176x faster
   imaging-darkroom                          120.542+-7.447            120.090+-6.239
   imaging-desaturate                         86.836+-1.174      ?      89.416+-2.912         ? might be 1.0297x slower
   imaging-gaussian-blur                     115.302+-7.178      ?     117.423+-3.950         ? might be 1.0184x slower
   json-parse-financial                       66.218+-2.932      ?      66.557+-2.817         ?
   json-stringify-tinderbox                   36.738+-1.433      ?      37.168+-1.208         ? might be 1.0117x slower
   stanford-crypto-aes                        60.736+-2.079             58.446+-1.851           might be 1.0392x faster
   stanford-crypto-ccm                        58.136+-2.163             55.471+-4.273           might be 1.0480x faster
   stanford-crypto-pbkdf2                     92.134+-3.772      ?      96.081+-3.898         ? might be 1.0428x slower
   stanford-crypto-sha256-iterative           33.160+-0.840             32.301+-1.616           might be 1.0266x faster

   <arithmetic>                               77.904+-0.863      ?      77.912+-1.243         ? might be 1.0001x slower

                                                 baseline                  patched
Geomean of preferred means:
   <scaled-result>                           23.7000+-0.1531           23.6056+-0.2233          might be 1.0040x faster
Comment 4 Yusuke Suzuki 2018-03-22 08:41:02 PDT
Committed r229852: <https://trac.webkit.org/changeset/229852>
Comment 5 Radar WebKit Bug Importer 2018-03-22 08:42:15 PDT
<rdar://problem/38752667>