RESOLVED FIXED 183894
appendQuotedJSONString stops on arithmetic overflow instead of propagating it upwards 
https://bugs.webkit.org/show_bug.cgi?id=183894
Summary appendQuotedJSONString stops on arithmetic overflow instead of propagating it...
Robin Morisset
Reported 2018-03-22 03:52:12 PDT
Created attachment 336270 [details] testcase This makes JSON.stringify on enormous strings crash instead of cleanly throwing an error. I am planning to fix it by making appendQuotedJSONString return a bool instead of void, with true meaning it succeeded, and false meaning the string turned out to be too big. rdar://problem/37005882
Attachments
testcase (70 bytes, application/x-javascript)
2018-03-22 03:52 PDT, Robin Morisset 		no flags
Details
Patch (5.99 KB, patch)
2018-03-23 05:13 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Patch (5.96 KB, patch)
2018-03-27 08:57 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2018-03-22 05:06:24 PDT
rdar://problem/37005882
Robin Morisset
Comment 2 2018-03-23 05:13:01 PDT
Created attachment 336365 [details] Patch
Robin Morisset
Comment 3 2018-03-27 08:57:30 PDT
Created attachment 336590 [details] Patch
Saam Barati
Comment 4 2018-03-27 10:00:15 PDT
Comment on attachment 336590 [details] Patch r=me
WebKit Commit Bot
Comment 5 2018-03-28 02:36:49 PDT
Comment on attachment 336590 [details] Patch Clearing flags on attachment: 336590 Committed r230026: <https://trac.webkit.org/changeset/230026>
WebKit Commit Bot
Comment 6 2018-03-28 02:36:51 PDT
All reviewed patches have been landed. Closing bug.
Robin Morisset
Comment 7 2018-03-30 07:48:40 PDT
*** Bug 181934 has been marked as a duplicate of this bug. ***
Robin Morisset
Comment 8 2018-03-30 07:49:56 PDT
*** Bug 182473 has been marked as a duplicate of this bug. ***
Yusuke Suzuki
Comment 9 2018-04-07 13:31:41 PDT
Committed r230371: <https://trac.webkit.org/changeset/230371>
Note You need to log in before you can comment on or make changes to this bug.