Bug 183882 - Adopt USE(OPENGL[_ES]) in more places
Summary: Adopt USE(OPENGL[_ES]) in more places
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-21 17:40 PDT by Tim Horton
Modified: 2018-03-22 11:37 PDT (History)
16 users (show)

See Also:

Attachments
Patch (25.72 KB, patch)
2018-03-21 17:41 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (26.04 KB, patch)
2018-03-21 17:55 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (25.54 KB, patch)
2018-03-21 17:57 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (27.13 KB, patch)
2018-03-21 18:13 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (27.73 KB, patch)
2018-03-21 23:17 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-03-21 17:40:34 PDT 
Adopt USE(OPENGL[_ES]) in more places
Comment 1 Tim Horton 2018-03-21 17:41:02 PDT 
Created attachment 336247 [details]
Patch
Comment 2 Tim Horton 2018-03-21 17:41:57 PDT 
<rdar://problem/37912195>
Comment 3 Tim Horton 2018-03-21 17:55:29 PDT 
Created attachment 336248 [details]
Patch
Comment 4 Tim Horton 2018-03-21 17:57:21 PDT 
Created attachment 336249 [details]
Patch
Comment 5 Tim Horton 2018-03-21 18:13:12 PDT 
Created attachment 336251 [details]
Patch
Comment 6 Sam Weinig 2018-03-21 21:28:31 PDT 
Comment on attachment 336251 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336251&action=review

> Source/WebCore/ChangeLog:8
> +        Adopt USE(OPENGL[_ES]) in more places
> +        https://bugs.webkit.org/show_bug.cgi?id=183882
> +        <rdar://problem/37912195>
> +
> +        Reviewed by NOBODY (OOPS!).
> +

This could use a terse why, even if that is just that being more specific makes things clearer.

> Source/WebCore/platform/graphics/cocoa/WebGLLayer.mm:67
> +#if USE(OPENGL)
>  // On Mac, we need to flip the layer to take into account

This comment feels a bit wrong now.
Comment 7 Tim Horton 2018-03-21 23:17:18 PDT 
Created attachment 336262 [details]
Patch
Comment 8 WebKit Commit Bot 2018-03-22 11:37:22 PDT 
Comment on attachment 336262 [details]
Patch

Clearing flags on attachment: 336262

Committed r229858: <https://trac.webkit.org/changeset/229858>
Comment 9 WebKit Commit Bot 2018-03-22 11:37:23 PDT 
All reviewed patches have been landed.  Closing bug.