WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
183882
Adopt USE(OPENGL[_ES]) in more places
https://bugs.webkit.org/show_bug.cgi?id=183882
Summary
Adopt USE(OPENGL[_ES]) in more places
Tim Horton
Reported
2018-03-21 17:40:34 PDT
Adopt USE(OPENGL[_ES]) in more places
Attachments
Patch
(25.72 KB, patch)
2018-03-21 17:41 PDT
,
Tim Horton
no flags
Details
Formatted Diff
Diff
Patch
(26.04 KB, patch)
2018-03-21 17:55 PDT
,
Tim Horton
no flags
Details
Formatted Diff
Diff
Patch
(25.54 KB, patch)
2018-03-21 17:57 PDT
,
Tim Horton
no flags
Details
Formatted Diff
Diff
Patch
(27.13 KB, patch)
2018-03-21 18:13 PDT
,
Tim Horton
no flags
Details
Formatted Diff
Diff
Patch
(27.73 KB, patch)
2018-03-21 23:17 PDT
,
Tim Horton
no flags
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2018-03-21 17:41:02 PDT
Created
attachment 336247
[details]
Patch
Tim Horton
Comment 2
2018-03-21 17:41:57 PDT
<
rdar://problem/37912195
>
Tim Horton
Comment 3
2018-03-21 17:55:29 PDT
Created
attachment 336248
[details]
Patch
Tim Horton
Comment 4
2018-03-21 17:57:21 PDT
Created
attachment 336249
[details]
Patch
Tim Horton
Comment 5
2018-03-21 18:13:12 PDT
Created
attachment 336251
[details]
Patch
Sam Weinig
Comment 6
2018-03-21 21:28:31 PDT
Comment on
attachment 336251
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=336251&action=review
> Source/WebCore/ChangeLog:8 > + Adopt USE(OPENGL[_ES]) in more places > +
https://bugs.webkit.org/show_bug.cgi?id=183882
> + <
rdar://problem/37912195
> > + > + Reviewed by NOBODY (OOPS!). > +
This could use a terse why, even if that is just that being more specific makes things clearer.
> Source/WebCore/platform/graphics/cocoa/WebGLLayer.mm:67 > +#if USE(OPENGL) > // On Mac, we need to flip the layer to take into account
This comment feels a bit wrong now.
Tim Horton
Comment 7
2018-03-21 23:17:18 PDT
Created
attachment 336262
[details]
Patch
WebKit Commit Bot
Comment 8
2018-03-22 11:37:22 PDT
Comment on
attachment 336262
[details]
Patch Clearing flags on attachment: 336262 Committed
r229858
: <
https://trac.webkit.org/changeset/229858
>
WebKit Commit Bot
Comment 9
2018-03-22 11:37:23 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug